Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vibrate support back in #58

Open
admwx7 opened this issue Sep 14, 2017 · 2 comments
Open

Add vibrate support back in #58

admwx7 opened this issue Sep 14, 2017 · 2 comments

Comments

@admwx7
Copy link
Collaborator

admwx7 commented Sep 14, 2017

Issue #55 pointed out an issue for us with using vibrate, a PR removed the functionality since it's passed the deprecation point and support was removed, however we want this functionality. Just need to figure out a way to do it that's not broken.

https://github.com/bendavis78/paper-time-picker/pull/57/files was the original code for it that was removed, for reference.

@admwx7 admwx7 added this to the 1.3 milestone Sep 19, 2017
@bendavis78
Copy link
Owner

Honestly I'm curious why the Chrome warning gets triggered at all, since the vibrate occurs during a user gesture (hence not an abuse of navigator.vibrate()). Perhaps this points to a bug in Chrome?

@admwx7
Copy link
Collaborator Author

admwx7 commented Oct 30, 2017

That's possible @bendavis78 I'll have to poke around at it and see what I can find, if it's still looking like a bug I'll reach out to the Polymer team on slack and see if they've encountered the like before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants