Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date library moment needed to be replaced #34

Open
satyaarthchhabra opened this issue Oct 18, 2021 · 9 comments
Open

Date library moment needed to be replaced #34

satyaarthchhabra opened this issue Oct 18, 2021 · 9 comments

Comments

@satyaarthchhabra
Copy link

I was reading code and found that we have used moment in a lot of places and it is needed to be replaced as it is being deprecated . can anyone suggest which library we should use instead of moment
@aquibbaig
Copy link
Contributor

I think day.js would be fine

@ruddi10
Copy link
Contributor

ruddi10 commented Oct 22, 2021

Hey @aquibbaig the datepicker that we use has dependency on moment so what should be done about that.

@rijusougata13
Copy link
Contributor

hey can I work on this?

@aquibbaig
Copy link
Contributor

@rijusougata13 go ahead 👍

@MihirK1212
Copy link

Is someone working on this, or can I give it a try?

@aquibbaig
Copy link
Contributor

go ahead

@MihirK1212
Copy link

i replaced Datetime with DatePicker which comes from 'react-dayjs-picker', however I am unable to find out which data type is
acceptable for date in handleStartChange

rohit-raje-786 added a commit to rohit-raje-786/dashboard that referenced this issue Jan 21, 2022
@rohit-raje-786
fixes : replace moment with dayjs issue bench-routes#34
fdecd37
@rohit-raje-786 rohit-raje-786 mentioned this issue Jan 21, 2022
Open
@rohit-raje-786
Copy link

@aquibbaig @ruddi10 I have resolved the issue could you please review it.

@aquibbaig
Copy link
Contributor

Thanks! Will review this weekend

rohit-raje-786 added a commit to rohit-raje-786/dashboard that referenced this issue Jan 21, 2022
@rohit-raje-786
replaced react-datetime with @material-ui/pickers issue bench-routes#34
65e4bb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@aquibbaig @rijusougata13 @satyaarthchhabra @ruddi10 @rohit-raje-786 @MihirK1212