Skip to content
This repository has been archived by the owner on Oct 18, 2022. It is now read-only.

Remove file globbing in favour of explicit controller imports #16

Open
ben-ryder opened this issue Jun 3, 2022 · 0 comments
Open

Remove file globbing in favour of explicit controller imports #16

ben-ryder opened this issue Jun 3, 2022 · 0 comments
Assignees
Labels
feature New feature or request
Milestone

Comments

@ben-ryder
Copy link
Owner

Package Information kangojs

Describe your feature
This is very similar to #7 but instead of adding explicit controller imports alongside the file globbing it should just be replaced.

Is your suggestion related to any problems?

  • With the new dependency injection system being written more and more functionality is being moved within the core framework. For example, it's likely that v2 will see the express app declaration move within KangoJS itself rather then the app be defined and managed by the end user. If users will be passing middleware and other things directly to KangoJS it makes sense that controllers should follow this same pattern.
  • As I start to add tests to the project the file globbing feature will make it much harder to test the framework as it's much harder to add specific controllers during tests.
  • Removing the feature will stop things like Controller loading doesn't work in compiled apps #2 from being an issue and removes "magic" functionality and makes the apps created using KangoJS easier to reason about.

Additional context
n/a

@ben-ryder ben-ryder added the feature New feature or request label Jun 3, 2022
@ben-ryder ben-ryder added this to the v2 milestone Jun 3, 2022
@ben-ryder ben-ryder self-assigned this Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant