Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable release #1

Open
rodrigoaguilera opened this issue Mar 14, 2021 · 7 comments
Open

Stable release #1

rodrigoaguilera opened this issue Mar 14, 2021 · 7 comments

Comments

@rodrigoaguilera
Copy link
Collaborator

I have some PHP8 scripts that build images and I would want to keep all dependencies updated so I replaced
https://packagist.org/packages/romantomchak/docker-php
for this client and it seems that all run good.

What are the steps you consider are needed for a stable v3 release?

From there we can maybe contact the previous developer so this fork is recommended as the replacement

@flavioheleno
Copy link
Member

Hi @rodrigoaguilera , first and foremost, I'm so terribly sorry for my lack of response! I've been running some other projects and dropped the ball on this one.

With that said, I think an in-depth review of this code would be required before I can tag a stable release.

Note that the current code is already stable, but it may have some dangling things that could be dropped.

@JanMikes
Copy link

Hi, i am looking for a replacement of the original docker-php package and this seems to be pretty much what i have been looking for (active, sf 6, php 8.1).

May i kindly ask you, what are your plans for the future? Honestly, im carefully picking my dependencies and i just want to get rid of fear of picking inactive fork of dead project 😂.

I am able to contribute and help with development.

@flavioheleno
Copy link
Member

Hi @JanMikes! I'm actively working on it (not as many hours as it needs, but it's still getting attention).

I've done a lot of work trying to find an alternative for JanePHP using the tools that Swagger/OpenAPI recommends but without much success (ie. the generated code quality was awful compared to what it's already here).

In the mean time, I'm trying to contribute to JanePHP in order to get rid of some of the issues that affect this project, as you can see in some other issues.

Anyways, I'm keeping this project maintained and will welcome contrib as well :-)

@JanMikes
Copy link

That sounds cool, thanks for the fast reply!

Im curious, have you considered taking over maintenance of the original docker-php/docker-php repo?

@flavioheleno
Copy link
Member

I've contributed to a few projects that are maintained by the same folk that used to maintain docker-php/docker-php and some of the contributions have been merged, some are still sitting there for years already, waiting his review/merge without any sort of activity, so although the idea has came to my mind at some point, the lack of response in other projects made me decide to fork it somewhere else.

Another driver for such decision is that I did not expect people to be interested in this as I was mainly using it to run builds in php-ext.com (which lacks a decent update).

So that's that :)

@flavioheleno
Copy link
Member

@rodrigoaguilera I've just created three new branches, 1.41, 1.42 and 1.43 and tagged three new releases (1.41.0, 1.42.0 and 1.43.0 respectively).
Each uses the referred Docker Engine API version, I think this is what you were looking for.

@rodrigoaguilera
Copy link
Collaborator Author

🤔 I was expecting a 3.x.x because there is already a 2.0.0 that appears as "more recent" on packagist.
https://packagist.org/packages/beluga-php/docker-php

Maybe 3.1.43 but that leaves no room for minor releases so maybe something like 3.1043.x. I'm adding a padding zero to take into a account a future 1.100 version of the docker API.

I haven't tested the new release but I'm happy to close this an open a discussion about how the release numbers should be.

Thanks for tagging the releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants