Bugfix-2071: Fixed bug where a double quote in the Formal Name would cause invalid strings. #2298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #2071 (details were also left on this comment #2071 (comment))
Formal Names with a double quote was causing invalid strings, this was causing the
post_gen_projecthook for MacOS to fail.Log error:
One proposed solution was to make the "fix" with
{{ cookiecutter.formal_name|replace('"', '\\"') }}on line 12 of the macOS post gen template scriptHowever, fixing this caused cascading issues (invalid strings) with the generation of the
briefcase.tomlcorresponding to the user's application build.See example for formal_name as
badFormalName"Solution:
Do not allow users to create an application with a formal name containing a double quote(s).
PR Checklist: