Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LinearFold for prediction of RNA secondary structure #361

Open
carreter opened this issue Sep 23, 2023 · 6 comments
Open

Implement LinearFold for prediction of RNA secondary structure #361

carreter opened this issue Sep 23, 2023 · 6 comments
Labels
easy A quick and easy fix! enhancement New feature or request medium priority The default priority for a new issue. stale
Milestone

Comments

@carreter
Copy link
Collaborator

No description provided.

@carreter carreter converted this from a draft issue Sep 23, 2023
@carreter carreter added this to the v1.0 milestone Sep 23, 2023
@carreter carreter added the needs-triage An issue that needs to be triaged label Sep 23, 2023
@carreter
Copy link
Collaborator Author

@TimothyStiles can you elaborate on what exactly it is we need here and triage the issue here + in the roadmap?

@Koeng101
Copy link
Contributor

Some context:

Linearfold is an RNA folding algorithm that works (basically) in linear time, which is pretty huge, because most algorithms are cubic. It is a newer algorithm and performs quite well, and can be implemented in code - unlike the (unfortunately better algorithms) which are implemented mostly using big ole AI models.

We were originally using it for RBS calculating - which I have more about here - #145 (comment)

As far as I know, we actually have linearfold working (and passing tests)- https://github.com/allyourbasepair/rbscalculator/blob/main/linearfold/linearfold.go

Unlike back then, I finally have the actual capacity to do testing, so we can get some in-vivo data.

@carreter carreter added enhancement New feature or request easy A quick and easy fix! medium priority The default priority for a new issue. and removed needs-triage An issue that needs to be triaged labels Sep 23, 2023
@abondrn
Copy link
Contributor

abondrn commented Oct 8, 2023

So I know, what is there left to do for this issue?

@Koeng101
Copy link
Contributor

So I know, what is there left to do for this issue?

Actually getting it committed into Poly proper. We haven't done any work to make sure it all still works, that it is inside this package, or comment it up better

@TimothyStiles
Copy link
Collaborator

I have some opinions on it. Essentially what's made implementing linear fold difficult is the source code doesn't really break down the algo into composable parts. If I remember correctly linear fold has a beam search component along with 3 other composable parts that when broken down may be easy to write and maintain.

Copy link

This issue has had no activity in the past 2 months. Marking as stale.

@github-actions github-actions bot added the stale label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy A quick and easy fix! enhancement New feature or request medium priority The default priority for a new issue. stale
Projects
None yet
Development

No branches or pull requests

4 participants