Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default CLOSE date for queries stored in the ledger #134

Open
dnicolodi opened this issue Jul 21, 2023 · 0 comments
Open

Default CLOSE date for queries stored in the ledger #134

dnicolodi opened this issue Jul 21, 2023 · 0 comments
Labels
proposal Request for comment on proposed changes

Comments

@dnicolodi
Copy link
Collaborator

dnicolodi commented Jul 21, 2023

According to the documentation for the query directive https://beancount.github.io/docs/beancount_language_syntax.html#query:

Also, the date of the query is intended to be the date at which the query is intended to be run for, that is, transactions following it should be ignored. If you’re familiar with the SQL syntax, it’s an implicit CLOSE.

However, when the code was origianlly written and till commit 6683356 this was not the case run from the beanquery shell as run query-name but only for queries run as part of run *.

I fear that implementing it for query execution that didn't implement it till now is going to break people workflows. However, I find the automatic CLOSE date functionality surprising enough that having it implemented only for queries executed with run * and not for other cases is just too confusing. Therefore, I'm reluctant to revert the change.

While I think that using the query directive date for the CLOSE clause is a neat idea, I'm tempted to keep things simple and just remove support for automatic CLOSE date and keep. What do you think? @blais do you use this functionality?

@dnicolodi dnicolodi added bug Something isn't working proposal Request for comment on proposed changes and removed bug Something isn't working labels Jul 21, 2023
@dnicolodi dnicolodi changed the title Default CLOSE date for queries stored in the ledger Default CLOSE date for queries stored in the ledger Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Request for comment on proposed changes
Projects
None yet
Development

No branches or pull requests

1 participant