-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributing Dietz method #27
Comments
Sure, sounds interesting. |
Perfect! Do you have a test beancount file to use? Also, I've done these three things. Please let me know if you'd merge them:
The last point comes with many changes to the structure of the file, like replacing os calls with pathlib for example. |
I don't have a test Beancount to use. We should probably generate one programmatically.
|
Excellent. I'll try to get the PR ready today. Regarding the usage of Poetry, I'd like to ping @andreasgerstmayr first. It would overwrite your |
Sure, as long as it's still a valid Python package which can be defined as a dependency of other projects :) |
Everything sounds good to me, except the conversion to Poetry. I don't like that it is not designed to compose with the rest of the Python packaging ecosystem, and I don't have time to learn a new way of doing things. What does Poetry bring to the project that cannot be implemented with other more standard tools? |
@andreasgerstmayr good to hear that. It should behave exactly like other packages. @dnicolodi how is it not designed to compose with the rest of the Python packaging system? You can still pip install it or use it as a dependency in a For example, you should be able to install it like:
PS: PPS: |
If installing the package is the only thing you want to do, you can do it without modifying the current |
Sorry, I edited the comment almost at the same time you commented. I'm not trying to force anything on anyone, I'm doing a PR and asked about this specifically. I'm open to change it, and I have it isolated in a commit so I could revert it. Poetry is the tool I use at work and in personal projects. It has been a very valuable tool for me in deploying Python packages. |
Hey there! Just wanted to share a bit. I intend to work a bit more on this, and publish it if possible. I just changed jobs so life got busy. I'll get to it soon tho. Cheers :) |
Hey!
I've been playing with the code for a while.
First, I packaged it with Poetry and Nix. It should be easy to release it to PyPi.
Secondly, using most of the logic from the current code, I changed the
compute_irr
forcompute_dietz
. There are some changes around the code on how the truncate works, but otherwise it's pretty much unchanged.Would you be interested in a PR for any of those things? It would be cool to have both the time and money weighted performance. It would also allow to add benchmarking.
The text was updated successfully, but these errors were encountered: