Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/user registration #18

Closed
wants to merge 6 commits into from
Closed

Feature/user registration #18

wants to merge 6 commits into from

Conversation

MICHAELMUNAVU83
Copy link
Collaborator

@MICHAELMUNAVU83 MICHAELMUNAVU83 commented Sep 7, 2023 •
edited by 75pollet
Loading

Fixes #5
In the pull request below , the following tasks were done .

  1. create a table on the database to save the user details to
  2. create the logic to save the details submitted by the user
  3. work on the UI (refer to the design provided above)
  4. Error handling on the form
  5. Write tests for this functionality

@MICHAELMUNAVU83 MICHAELMUNAVU83 self-assigned this Sep 7, 2023
@MICHAELMUNAVU83 MICHAELMUNAVU83 linked an issue Sep 7, 2023 that may be closed by this pull request
user registration #5
Open
5 tasks
manuelgeek
manuelgeek reviewed Sep 7, 2023
View reviewed changes
lib/elixir_conf_africa/users/user.ex
field :confirmed_at, :naive_datetime
field :first_name, :string
field :last_name, :string
field :country, :string
Copy link
Member

@manuelgeek manuelgeek Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've not discussed db strucure, but I would suggest we have an accounts table
this is too much info for a users table

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay , I will wait for the db structure discussion at 6 pm then restructure accordingly

@okothkongo
Copy link
Collaborator

@MICHAELMUNAVU83 This is a good job, especially the UI 👍

I believe this fixes 3 issues at hand:

  1. The creation/ registration of a user
  2. Login
  3. Password reset

Kindly ensure that when moving this issue on the board, you also move its associated issues.

@75pollet WDYT?

My other take though not mandatory you can always share a gif or screenshot when a PR involves UI.

Also, I noticed you improved our test coverage to 98.2%, you setting a high standard 😄 , Kindly adjust the value in
coveralls.json file to keep this high standard, i.e.

  
  "coverage_options": {
    "minimum_coverage": 98.2
  },
  "skip_files": ["lib/elixir_conf_africa_web/components/core_components.ex"]
}

I will hold my approval until the DB structure is agreed upon, but everything is great and looks good to me as it is

@MICHAELMUNAVU83 MICHAELMUNAVU83 deleted the feature/user-registration branch October 18, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelgeek manuelgeek manuelgeek left review comments

@sigu sigu Awaiting requested review from sigu

@75pollet 75pollet Awaiting requested review from 75pollet

Assignees

@MICHAELMUNAVU83 MICHAELMUNAVU83

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user registration
3 participants
@MICHAELMUNAVU83 @okothkongo @manuelgeek