-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update comms cape overlay #175
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few extra comments would be great.
/* identification */ | ||
part-number = "BBORG_COMMS"; | ||
version = "00A2"; | ||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something wrong with your tabs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, It seems like that. Everything looks good with vscode but not here :(
src/arm/BBORG_COMMS-00A2.dts
Outdated
&am33xx_pinmux { | ||
bborg_comms_can_pins: pinmux_comms_can_pins { | ||
pinctrl-single,pins = < | ||
BONE_P9_24 (PIN_INPUT_PULLUP | MUX_MODE2) /* P9_24: uart1_txd.d_can1_rx */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this eventually be an include of the virtual cape?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what do you mean by that. This overlay and the servo cape overlay will be updated to use the new bone bus type format as soon as I test the I2C buses on BBB and BBAI (same binary).
src/arm/BBORG_COMMS-00A2.dts
Outdated
status = "okay"; | ||
pinctrl-names = "default"; | ||
pinctrl-0 = <&bborg_comms_rs485_pins>; | ||
//rs485-rts-delay = <0 0>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't these need to be enabled? When should they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess when you need Request To Send (RTS) signal.
src/arm/BBORG_COMMS-00A2.dts
Outdated
BONE_P9_11 (PIN_INPUT | MUX_MODE6) /* P9_11: gpmc_wait0.uart4_rxd_mux2 */ | ||
>; | ||
}; | ||
sink@1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the udev rules good to enable these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RS585 seems to be working fine, I have not tested CAN with my MCP2515 CAN module yet. Is there something special with these to require special treatment from udev rules?
@RobertCNelson Hi,
I have updated this overlay with sink nodes and it's using the new format of DT now :)
Everything has been tested on BBBWL