Skip to content

Commit 21c3aaf

Browse files
committed
Merge branch 'release/0.9.0'
2 parents 2c80abb + 36dc9de commit 21c3aaf

File tree

80 files changed

+502
-513
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

80 files changed

+502
-513
lines changed

.codecov.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
coverage:
22
ignore:
3-
- Carthage/*
4-
- Example/*
5-
- ExampleUITests/*
6-
- QuickTableViewControllerTests/*
7-
- Pods/*
3+
- "Carthage/**/*"
4+
- "Example*/**/*"
5+
- "*Tests/**/*"
6+
- "Pods/**/*"

.jazzy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ github_url: https://github.com/bcylin/QuickTableViewController
55
github_file_prefix: https://github.com/bcylin/QuickTableViewController/blob/develop
66
xcodebuild_arguments: [-project, QuickTableViewController.xcodeproj, -scheme, QuickTableViewController-iOS]
77
module: QuickTableViewController
8-
module_version: 0.8.4
8+
module_version: 0.9.0
99
output: docs/output
1010
theme: fullwidth
1111
skip_undocumented: true

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
language: objective-c
2-
osx_image: xcode9
2+
osx_image: xcode9.2
33
matrix:
44
include:
55
- env: VERSION=latest
@@ -17,11 +17,11 @@ before_script:
1717
- if [ -n "$DANGER_GITHUB_API_TOKEN" ]; then bundle exec danger; fi
1818
script:
1919
- bundle exec rake ci:test[QuickTableViewController-iOS]
20-
- bundle exec rake ci:test[Example]
20+
- bash <(curl -s https://codecov.io/bash) -cF ios -J "QuickTableViewController"
21+
- bundle exec rake ci:test[Example-iOS]
2122
- make -B carthage
2223
- make -B docs
2324
after_success:
24-
# - bash <(curl -s https://codecov.io/bash) -cF ios
2525
- sh scripts/update-docs.sh
2626
notifications:
2727
email: false

CHANGELOG.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,26 @@
11
# Change Log
22

3+
## v0.9.0
4+
5+
#### Breaking
6+
7+
* Change the `Icon` type (since [v0.2.0](#v020)) from struct to enum:
8+
9+
```swift
10+
enum Icon {
11+
case named(String)
12+
case image(UIImage)
13+
case images(normal: UIImage, highlighted: UIImage)
14+
}
15+
```
16+
17+
* Rename the protocols (introduced in [v0.8.1](#v081)) that define specific rows regardless of their associated cell types:
18+
19+
* `NavigationRowCompatible`
20+
* `OptionSelectable``OptionRowCompatible`
21+
* `Switchable``SwitchRowCompatible`
22+
* `Tappable``TapActionRowCompatible`
23+
324
## v0.8.4
425

526
#### Fixes
File renamed without changes.

Example/Assets.xcassets/AppIcon.appiconset/Contents.json renamed to Example-iOS/Assets.xcassets/AppIcon.appiconset/Contents.json

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
{
22
"images" : [
3+
{
4+
"idiom" : "iphone",
5+
"size" : "20x20",
6+
"scale" : "2x"
7+
},
8+
{
9+
"idiom" : "iphone",
10+
"size" : "20x20",
11+
"scale" : "3x"
12+
},
313
{
414
"idiom" : "iphone",
515
"size" : "29x29",
@@ -29,6 +39,11 @@
2939
"idiom" : "iphone",
3040
"size" : "60x60",
3141
"scale" : "3x"
42+
},
43+
{
44+
"idiom" : "ios-marketing",
45+
"size" : "1024x1024",
46+
"scale" : "1x"
3247
}
3348
],
3449
"info" : {

Example/Info.plist renamed to Example-iOS/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<key>CFBundlePackageType</key>
1818
<string>APPL</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>0.8.4</string>
20+
<string>0.9.0</string>
2121
<key>CFBundleVersion</key>
2222
<string>101</string>
2323
<key>LSRequiresIPhoneOS</key>
File renamed without changes.
File renamed without changes.

Example/ViewControllers/CustomizationViewController.swift renamed to Example-iOS/ViewControllers/CustomizationViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ internal final class CustomizationViewController: QuickTableViewController {
9797
// MARK: - Private
9898

9999
private func log(_ sender: Row) {
100-
if let option = sender as? OptionSelectable, !option.isSelected {
100+
if let option = sender as? OptionRowCompatible, !option.isSelected {
101101
return
102102
}
103103

Example/ViewControllers/DefaultViewController.swift renamed to Example-iOS/ViewControllers/DefaultViewController.swift

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,18 +46,18 @@ internal final class DefaultViewController: QuickTableViewController {
4646

4747
tableContents = [
4848
Section(title: "Switch", rows: [
49-
SwitchRow(title: "Setting 1", switchValue: true, icon: Icon(image: globe), action: weakify(self, type(of: self).didToggleSwitch)),
50-
SwitchRow(title: "Setting 2", switchValue: false, icon: Icon(image: time), action: weakify(self, type(of: self).didToggleSwitch))
49+
SwitchRow(title: "Setting 1", switchValue: true, icon: .image(globe), action: weakify(self, type(of: self).didToggleSwitch)),
50+
SwitchRow(title: "Setting 2", switchValue: false, icon: .image(time), action: weakify(self, type(of: self).didToggleSwitch))
5151
]),
5252

5353
Section(title: "Tap Action", rows: [
5454
TapActionRow(title: "Tap action", action: weakify(self, type(of: self).showAlert))
5555
]),
5656

5757
Section(title: "Navigation", rows: [
58-
NavigationRow(title: "CellStyle.default", subtitle: .none, icon: Icon(image: gear)),
59-
NavigationRow(title: "CellStyle", subtitle: .belowTitle(".subtitle"), icon: Icon(image: globe)),
60-
NavigationRow(title: "CellStyle", subtitle: .rightAligned(".value1"), icon: Icon(image: time), action: weakify(self, type(of: self).showDetail)),
58+
NavigationRow(title: "CellStyle.default", subtitle: .none, icon: .image(gear)),
59+
NavigationRow(title: "CellStyle", subtitle: .belowTitle(".subtitle"), icon: .image(globe)),
60+
NavigationRow(title: "CellStyle", subtitle: .rightAligned(".value1"), icon: .image(time), action: weakify(self, type(of: self).showDetail)),
6161
NavigationRow(title: "CellStyle", subtitle: .leftAligned(".value2"))
6262
], footer: "UITableViewCellStyle.Value2 hides the image view."),
6363

@@ -82,7 +82,7 @@ internal final class DefaultViewController: QuickTableViewController {
8282
// MARK: - Private Methods
8383

8484
private func didToggleSelection(_ sender: Row) {
85-
guard let option = sender as? OptionSelectable else {
85+
guard let option = sender as? OptionRowCompatible else {
8686
return
8787
}
8888
let state = "\(option.title) is " + (option.isSelected ? "selected" : "deselected")
@@ -91,7 +91,7 @@ internal final class DefaultViewController: QuickTableViewController {
9191
}
9292

9393
private func didToggleSwitch(_ sender: Row) {
94-
if let row = sender as? Switchable {
94+
if let row = sender as? SwitchRowCompatible {
9595
let state = "\(row.title) = \(row.switchValue)"
9696
print(state)
9797
showDebuggingText(state)

ExampleUITests/Info.plist renamed to Example-iOSUITests/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<key>CFBundlePackageType</key>
1616
<string>BNDL</string>
1717
<key>CFBundleShortVersionString</key>
18-
<string>0.8.4</string>
18+
<string>0.9.0</string>
1919
<key>CFBundleVersion</key>
2020
<string>1</string>
2121
</dict>

Gemfile.lock

Lines changed: 34 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,45 @@
11
GEM
22
remote: http://rubygems.org/
33
specs:
4-
CFPropertyList (2.3.6)
4+
CFPropertyList (3.0.0)
55
activesupport (4.2.10)
66
i18n (~> 0.7)
77
minitest (~> 5.1)
88
thread_safe (~> 0.3, >= 0.3.4)
99
tzinfo (~> 1.1)
1010
addressable (2.5.2)
1111
public_suffix (>= 2.0.2, < 4.0)
12+
atomos (0.1.2)
1213
claide (1.0.2)
1314
claide-plugins (0.9.2)
1415
cork
1516
nap
1617
open4 (~> 1.3)
17-
cocoapods (1.3.1)
18+
cocoapods (1.5.0)
1819
activesupport (>= 4.0.2, < 5)
1920
claide (>= 1.0.2, < 2.0)
20-
cocoapods-core (= 1.3.1)
21-
cocoapods-deintegrate (>= 1.0.1, < 2.0)
22-
cocoapods-downloader (>= 1.1.3, < 2.0)
21+
cocoapods-core (= 1.5.0)
22+
cocoapods-deintegrate (>= 1.0.2, < 2.0)
23+
cocoapods-downloader (>= 1.2.0, < 2.0)
2324
cocoapods-plugins (>= 1.0.0, < 2.0)
2425
cocoapods-search (>= 1.0.0, < 2.0)
2526
cocoapods-stats (>= 1.0.0, < 2.0)
26-
cocoapods-trunk (>= 1.2.0, < 2.0)
27+
cocoapods-trunk (>= 1.3.0, < 2.0)
2728
cocoapods-try (>= 1.1.0, < 2.0)
2829
colored2 (~> 3.1)
2930
escape (~> 0.0.4)
3031
fourflusher (~> 2.0.1)
3132
gh_inspector (~> 1.0)
32-
molinillo (~> 0.5.7)
33+
molinillo (~> 0.6.5)
3334
nap (~> 1.0)
3435
ruby-macho (~> 1.1)
35-
xcodeproj (>= 1.5.1, < 2.0)
36-
cocoapods-core (1.3.1)
36+
xcodeproj (>= 1.5.7, < 2.0)
37+
cocoapods-core (1.5.0)
3738
activesupport (>= 4.0.2, < 6)
3839
fuzzy_match (~> 2.0.4)
3940
nap (~> 1.0)
40-
cocoapods-deintegrate (1.0.1)
41-
cocoapods-downloader (1.1.3)
41+
cocoapods-deintegrate (1.0.2)
42+
cocoapods-downloader (1.2.0)
4243
cocoapods-plugins (1.0.0)
4344
nap
4445
cocoapods-search (1.0.0)
@@ -51,7 +52,7 @@ GEM
5152
concurrent-ruby (1.0.5)
5253
cork (0.3.0)
5354
colored2 (~> 3.1)
54-
danger (5.5.5)
55+
danger (5.5.11)
5556
claide (~> 1.0)
5657
claide-plugins (>= 0.9.2)
5758
colored2 (~> 3.1)
@@ -64,48 +65,48 @@ GEM
6465
octokit (~> 4.7)
6566
terminal-table (~> 1)
6667
escape (0.0.4)
67-
faraday (0.13.1)
68+
faraday (0.14.0)
6869
multipart-post (>= 1.2, < 3)
6970
faraday-http-cache (1.3.1)
7071
faraday (~> 0.8)
71-
ffi (1.9.18)
72+
ffi (1.9.23)
7273
fourflusher (2.0.1)
7374
fuzzy_match (2.0.4)
74-
gh_inspector (1.0.3)
75+
gh_inspector (1.1.3)
7576
git (1.3.0)
76-
i18n (0.9.1)
77+
i18n (0.9.5)
7778
concurrent-ruby (~> 1.0)
78-
jazzy (0.9.0)
79+
jazzy (0.9.1)
7980
cocoapods (~> 1.0)
8081
mustache (~> 0.99)
8182
open4
8283
redcarpet (~> 3.2)
83-
rouge (~> 1.5)
84+
rouge (>= 2.0.6, < 4.0)
8485
sass (~> 3.4)
8586
sqlite3 (~> 1.3)
8687
xcinvoke (~> 0.3.0)
8788
kramdown (1.16.2)
8889
liferaft (0.0.6)
89-
minitest (5.10.3)
90-
molinillo (0.5.7)
90+
minitest (5.11.3)
91+
molinillo (0.6.5)
9192
multipart-post (2.0.0)
9293
mustache (0.99.8)
93-
nanaimo (0.2.3)
94+
nanaimo (0.2.5)
9495
nap (1.1.0)
9596
netrc (0.11.0)
9697
no_proxy_fix (0.1.2)
9798
octokit (4.8.0)
9899
sawyer (~> 0.8.0, >= 0.5.3)
99100
open4 (1.3.4)
100-
public_suffix (3.0.1)
101-
rake (12.3.0)
102-
rb-fsevent (0.10.2)
101+
public_suffix (3.0.2)
102+
rake (12.3.1)
103+
rb-fsevent (0.10.3)
103104
rb-inotify (0.9.10)
104105
ffi (>= 0.5.0, < 2)
105106
redcarpet (3.4.0)
106-
rouge (1.11.1)
107+
rouge (2.0.7)
107108
ruby-macho (1.1.0)
108-
sass (3.5.4)
109+
sass (3.5.6)
109110
sass-listen (~> 4.0.0)
110111
sass-listen (4.0.0)
111112
rb-fsevent (~> 0.9, >= 0.9.4)
@@ -117,18 +118,19 @@ GEM
117118
terminal-table (1.8.0)
118119
unicode-display_width (~> 1.1, >= 1.1.1)
119120
thread_safe (0.3.6)
120-
tzinfo (1.2.4)
121+
tzinfo (1.2.5)
121122
thread_safe (~> 0.1)
122123
unicode-display_width (1.3.0)
123124
xcinvoke (0.3.0)
124125
liferaft (~> 0.0.6)
125-
xcodeproj (1.5.4)
126-
CFPropertyList (~> 2.3.3)
126+
xcodeproj (1.5.7)
127+
CFPropertyList (>= 2.3.3, < 4.0)
128+
atomos (~> 0.1.2)
127129
claide (>= 1.0.2, < 2.0)
128130
colored2 (~> 3.1)
129-
nanaimo (~> 0.2.3)
130-
xcpretty (0.2.6)
131-
rouge (~> 1.8)
131+
nanaimo (~> 0.2.4)
132+
xcpretty (0.2.8)
133+
rouge (~> 2.0.7)
132134

133135
PLATFORMS
134136
ruby

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ default: test
22

33
test:
44
bundle exec rake 'ci:test[QuickTableViewController-iOS]'
5-
bundle exec rake 'ci:test[Example]'
5+
bundle exec rake 'ci:test[Example-iOS]'
66

77
ci-test: test
88
make -B carthage

Podfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ use_frameworks!
44
workspace "QuickTableViewController"
55
project "QuickTableViewController"
66

7-
target "QuickTableViewControllerTests-iOS" do
8-
pod "Nimble", git: "https://github.com/Quick/Nimble.git", tag: "v7.0.2"
7+
target "QuickTableViewController-iOSTests" do
8+
pod "Nimble", git: "https://github.com/Quick/Nimble.git", tag: "v7.0.3"
99
pod "Quick", git: "https://github.com/Quick/Quick.git", tag: "v1.2.0"
1010
end
1111

12-
target "Example" do
13-
pod "SwiftLint", "0.23.1"
12+
target "Example-iOS" do
13+
pod "SwiftLint", podspec: "https://raw.githubusercontent.com/CocoaPods/Specs/master/Specs/4/0/1/SwiftLint/0.25.0/SwiftLint.podspec.json"
1414
pod "Weakify", git: "https://github.com/klundberg/Weakify.git", tag: "v0.4.0"
1515
end

0 commit comments

Comments
 (0)