From c05421ee0f925ac8e4dcf90cd37893df82b10f33 Mon Sep 17 00:00:00 2001 From: Brandon Kauffman Date: Tue, 24 Sep 2024 20:09:41 -0400 Subject: [PATCH] migrate metrics path to /metrics This resolves #3597 --- README.md | 2 +- dev/helm-local.yml | 2 +- engine/engine/urls.py | 2 +- helm/oncall/values.yaml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 510a4a628b..f3a28d7054 100644 --- a/README.md +++ b/README.md @@ -71,7 +71,7 @@ We prepared multiple environments: scrape_configs: - job_name: prometheus - metrics_path: /metrics/ + metrics_path: /metrics authorization: credentials: my_random_prometheus_secret static_configs: diff --git a/dev/helm-local.yml b/dev/helm-local.yml index b5fd80492d..303deea285 100644 --- a/dev/helm-local.yml +++ b/dev/helm-local.yml @@ -152,7 +152,7 @@ prometheus: scrape_interval: 10s extraScrapeConfigs: | - job_name: 'oncall-exporter' - metrics_path: /metrics/ + metrics_path: /metrics static_configs: - targets: - oncall-dev-engine.default.svc.cluster.local:8080 diff --git a/engine/engine/urls.py b/engine/engine/urls.py index 1a2f933998..cce2ba29b7 100644 --- a/engine/engine/urls.py +++ b/engine/engine/urls.py @@ -48,7 +48,7 @@ if settings.FEATURE_PROMETHEUS_EXPORTER_ENABLED: urlpatterns += [ - path("metrics/", include("apps.metrics_exporter.urls")), + path("metrics", include("apps.metrics_exporter.urls")), ] if settings.FEATURE_TELEGRAM_INTEGRATION_ENABLED: diff --git a/helm/oncall/values.yaml b/helm/oncall/values.yaml index 8ca59a2664..893cdcb85d 100644 --- a/helm/oncall/values.yaml +++ b/helm/oncall/values.yaml @@ -722,7 +722,7 @@ prometheus: enabled: false # extraScrapeConfigs: | # - job_name: 'oncall-exporter' - # metrics_path: /metrics/ + # metrics_path: /metrics # static_configs: # - targets: # - oncall-dev-engine.default.svc.cluster.local:8080