-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.jshintignore, .jshintrc #22
Comments
@brenmcnamara I intended to assign this to you but it doesn't look like you're a collaborator yet. To make that happen check this link: https://github.com/bchurchill/badi-cal/invitations. |
Since you're already using ESLint, I don't think you actually want those files created, and from a quick glance at your code, I don't see how they were created as it seems it should be making ESLint files instead. |
Btw, feel free to start a wiki page on @bahaidev listing Baha'i-related repos such as this one (if not the repo itself). |
Btw, |
You can thank @brenmcnamara for that! I'm a foreigner in these vast and spacious lands of javascript... |
Sorry for responding so late. I'm not sure how they got created but you don't want those files. We are using ESLint. These files are for configuring rules that check for javascript code quality. I can try to see why these files were created. This isn't a breaking issue though. Whether you commit those files or not, things should work fine. |
@brettz9 - It doesn't look like the Baha'i Dev organization has any owners. How can we add or get access to repos? Thanks! |
When logging on recently, Github suggested renaming the "Owners" team since that team is no longer used to determine ownership (that is instead now handled by "roles"). I did just now add a "Collaborators" team as a general umbrella group, however, and added my TextBrowser repo to it (though if our numbers start getting unwieldy (a welcome development!), I might change to have teams for each repository along with any teams that combine repository access for related projects or teams for long-time contributing team members). For future reference, as long is one is already a member of the organization (in this case, bahaidev), one can ask to join any (non-"secret") team in the organization. But in this case, I've already added you both as members to that umbrella team (though in your case, @brenmcnamara , you'll first need to agree to join the organization, but after that, you should already have access to the group, and thus to TextBrowser (and any other repos you might wish to add for that team)). |
After running
npm run clean-build
andnpm run create-build
there were two new files created,.jshintignore
and.jshintrc
. I don't know the best practice for handling these files in version control (or what they do, frankly), so perhaps we can decide if they should be added to the .gitignore or committed into the repository?The text was updated successfully, but these errors were encountered: