You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replace it with fdir (1M downloads / wk) and picomatch (50m downloads / wk)
I originally proposed replacing it with tinyglobby in Use tinyglobby for globbing #622. See that PR for the full background and additional details regarding this issue
Split this package into CLI and core. The CLI could retain the name json-schema-to-typescript and re-export the stuff contained in core, so that users could continue to install just the one package they need and the change could be made in a backwards-compatible fashion. This would also remove other packages like minimist and is-glob from the core dependencies as well
The text was updated successfully, but these errors were encountered:
it is worth noting that choosing your dependencies purely based on number of downloads isn't the best idea (re the closed PR)
fdir is much faster than existing glob libraries, even when combined with picomatch (to provide glob functionality). tinyglobby does not have as many downloads but is built on top of fdir, which is a well established library.
this repo would benefit from the performance improvement, and from reduction in install size
splitting the package seems like a larger effort that should be discussed/worked on at some other later point
glob
is responsible for 26 out of 37 dependencies for this library: https://npmgraph.js.org/?q=json-schema-to-typescript. I'd love to see if we can find a way to reduce that.A few options I can think of:
fdir
(1M downloads / wk) andpicomatch
(50m downloads / wk)tinyglobby
in Use tinyglobby for globbing #622. See that PR for the full background and additional details regarding this issuejson-schema-to-typescript
and re-export the stuff contained in core, so that users could continue to install just the one package they need and the change could be made in a backwards-compatible fashion. This would also remove other packages likeminimist
andis-glob
from the core dependencies as wellThe text was updated successfully, but these errors were encountered: