Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh_CN dataset to latest #548

Open
EminemJK opened this issue May 11, 2024 · 3 comments
Open

Update zh_CN dataset to latest #548

EminemJK opened this issue May 11, 2024 · 3 comments
Labels
dataset-update resolved by updating faker.js data sets enhancement future

Comments

@EminemJK
Copy link

Bogus NuGet Package

35.5.1

.NET Version

.Net6

Visual Studio Version

17.8

What operating system are you using?

Windows

What locale are you using with Bogus?

zh_CN

What's the problem?

For the first time, I find this is a very good code base, but unfortunately it lacks most Chinese data, I am happy to provide data for it, please tell me how to supplement the data resources.

Provide LINQPad Example

.

What other possible solutions or alternatives have you considered?

.

@digitalcoyote
Copy link
Contributor

@EminemJK since Bogus gets most of its data from faker.js, if you're willing to contribute upstream instead, it would help more projects to get Chinese data.

@bchavez
Copy link
Owner

bchavez commented May 11, 2024

Thank you for your interest in supporting the project. Yes as @digitalcoyote mentioned, the best approach is to contribute upstream to faker.js for locale data.

https://github.com/faker-js/faker

Once you've done that, you can add a GH issue here to request and track the zh_CN update.

Eventually Bogus will pull locale updates from faker.js. Pulling locale updates from faker.js is my next block of work on the roadmap but this process takes a while because I have to be really careful dealing with breaking changes and understanding well any unit tests that might break.

@bchavez bchavez changed the title I would like to provide data for Bogus Update zh_CN dataset to latest May 12, 2024
@bchavez bchavez added enhancement future dataset-update resolved by updating faker.js data sets and removed question labels May 12, 2024
@EminemJK
Copy link
Author

Sure, I'll take a look at faker.js. As a developer from China, I've also noticed some Chinese syntax issues in the Bogus library, such as with names. In Chinese, the naming convention is to put the surname before the given name, which is the opposite of English names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataset-update resolved by updating faker.js data sets enhancement future
Projects
None yet
Development

No branches or pull requests

3 participants