Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESENG-694: Update timeline widget design #2596

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

NatSquared
Copy link
Contributor

@NatSquared NatSquared commented Sep 27, 2024

Issue #: https://citz-gdx.atlassian.net/browse/DESENG-694

Description of changes:

  • Feature New Timeline Widget designs
    • Implemented Figma design
    • Adjusted styling in Engagement views slightly to accommodate theme-aware widgets

User Guide update ticket (if applicable):
https://citz-gdx.atlassian.net/browse/DESENG-720

Copy link

sonarcloud bot commented Sep 27, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 43.47826% with 13 lines in your changes missing coverage. Please review.

Project coverage is 75.17%. Comparing base (d735284) to head (bf9b49b).

Files with missing lines Patch % Lines
...t/old-view/widgets/Timeline/TimelineWidgetView.tsx 40.90% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2596      +/-   ##
==========================================
+ Coverage   75.10%   75.17%   +0.06%     
==========================================
  Files         612      612              
  Lines       22247    22224      -23     
  Branches     1869     1866       -3     
==========================================
- Hits        16708    16706       -2     
+ Misses       5266     5247      -19     
+ Partials      273      271       -2     
Flag Coverage Δ
metweb 64.22% <43.47%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
met-web/src/components/common/Input/Select.tsx 91.66% <ø> (ø)
met-web/src/components/common/Typography/index.tsx 100.00% <100.00%> (ø)
met-web/src/styles/Theme.ts 100.00% <ø> (ø)
...t/old-view/widgets/Timeline/TimelineWidgetView.tsx 48.00% <40.90%> (+18.83%) ⬆️

Copy link
Collaborator

@Baelx Baelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the redesign! No issues

@NatSquared NatSquared merged commit 0b61f80 into main Oct 1, 2024
8 checks passed
@NatSquared NatSquared deleted the feature/DESENG-694-update-timeline-widget branch October 1, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants