From 48f74883d45cc07bfea774c19adfed3169efad5b Mon Sep 17 00:00:00 2001 From: Jad Date: Tue, 18 Jul 2023 16:01:31 -0700 Subject: [PATCH] Fix view survey error on engagement listing DD --- .../components/engagement/listing/ActionsDropDown.tsx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/met-web/src/components/engagement/listing/ActionsDropDown.tsx b/met-web/src/components/engagement/listing/ActionsDropDown.tsx index 722aac0f7..fc8155608 100644 --- a/met-web/src/components/engagement/listing/ActionsDropDown.tsx +++ b/met-web/src/components/engagement/listing/ActionsDropDown.tsx @@ -58,11 +58,15 @@ export const ActionsDropDown = ({ engagement }: { engagement: Engagement }) => { }; const canViewSurvey = (): boolean => { - if (engagement.engagement_status.id === EngagementStatus.Draft) { - return roles.includes(USER_ROLES.VIEW_ALL_SURVEYS) || assignedEngagements.includes(engagement.id); + if (engagement.engagement_status.id !== EngagementStatus.Draft) { + return true; } - return true; + if (engagement.surveys.length === 0) { + return false; + } + + return roles.includes(USER_ROLES.VIEW_ALL_SURVEYS) || assignedEngagements.includes(engagement.id); }; const ITEMS: ActionDropDownItem[] = useMemo(