From d3440c11a192dc339a2933b050d8c3752103a250 Mon Sep 17 00:00:00 2001 From: Ratheesh kumar R <108045773+ratheesh-aot@users.noreply.github.com> Date: Wed, 28 Feb 2024 09:24:37 -0800 Subject: [PATCH] DESENG-496: Fixed Comments cannot be approved (#2398) Added missing transactional decorator --- CHANGELOG.MD | 2 ++ met-api/src/met_api/services/submission_service.py | 1 + 2 files changed, 3 insertions(+) diff --git a/CHANGELOG.MD b/CHANGELOG.MD index 361f52f4a..380b39045 100644 --- a/CHANGELOG.MD +++ b/CHANGELOG.MD @@ -1,4 +1,6 @@ ## February 27, 2024 +- **Bug Fix**Comments cannot be approved while reviewing [DESENG-496](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-496) + - Fixed by adding a missing decorator for transactional methods. - **Task**Enhance analytics api for Improved Readability and Maintainability [DESENG-492](https://apps.itsm.gov.bc.ca/jira/browse/DESENG-492) - Refactor analytics-api config to harmonize its structure and conventions with met-api. - Ensure the sample.env file maintains consistent formatting. diff --git a/met-api/src/met_api/services/submission_service.py b/met-api/src/met_api/services/submission_service.py index abfeb3410..9e640c862 100644 --- a/met-api/src/met_api/services/submission_service.py +++ b/met-api/src/met_api/services/submission_service.py @@ -144,6 +144,7 @@ def _validate_fields(submission): raise ValueError('Engagement not open to submissions') @classmethod + @transactional() def review_comment(cls, submission_id, staff_review_details: dict, external_user_id) -> SubmissionSchema: """Review comment.""" user = StaffUserService.get_user_by_external_id(external_user_id)