Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit able not work i can not edit text #245

Closed
dash7ou opened this issue Aug 19, 2020 · 7 comments
Closed

edit able not work i can not edit text #245

dash7ou opened this issue Aug 19, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@dash7ou
Copy link

dash7ou commented Aug 19, 2020

isEditable={true} but i can not edit text in browser?!

@dash7ou dash7ou added the bug Something isn't working label Aug 19, 2020
@dash7ou dash7ou closed this as completed Aug 29, 2020
@pietrop
Copy link
Contributor

pietrop commented Aug 29, 2020

@dash7ou did you figure it out?

@dash7ou
Copy link
Author

dash7ou commented Aug 29, 2020

no, but no one reply to me?
this is my code:-
<TranscriptEditor
transcriptData={transcribeData.versionData.text_json}
mediaUrl={${process.env.REACT_APP_S3_BACKET}/${process.env.REACT_APP_S3_ENV}${transcribeData.video}}
isEditable={true}
sttJsonType={transcribeData.versionData.text_json.hasOwnProperty("jobName") ? "amazontranscribe" : "draftjs"}
mediaType={transcribeData.mimeType}
handleAutoSaveChanges={handleAutoSaveChanges}
autoSaveContentType={"draftjs"}
/>

but edit text not work edit owner work perfect but transcript text not work.

@pietrop
Copy link
Contributor

pietrop commented Aug 29, 2020

What version of TranscriptEditor are you using?
I couldn't reproduce the issue in the storybook demo (by checking and unchecking the "Text Is Editable" option)

@dash7ou
Copy link
Author

dash7ou commented Aug 29, 2020

this is TranscriptEditor ^1.4.1-alpha.8 version I am using now

@dash7ou
Copy link
Author

dash7ou commented Aug 29, 2020

I know no problem with demo in the storybook but I add isEditable={true} I think it should work right?

@pietrop
Copy link
Contributor

pietrop commented Aug 29, 2020

Yes, correct, I think there was a problem with one of the alpha releases.
see this issue #237 and this comment #237 (comment)

@jamesdools will be able to confirm (or push an update so that the latest release is a working one?)

For now, I'd revert back to a non alpha release eg 1.4.1, if that makes sense?

@dash7ou
Copy link
Author

dash7ou commented Aug 30, 2020

ok thanks for your help and your time 3>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants