Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaPlayer resumes play when I click the 'delete' button or arrow buttons multiple times #214

Open
NickRuiz opened this issue Nov 11, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@NickRuiz
Copy link

Describe the bug
When tapping the 'delete' key several times to remove words or spaces, the player resumes play.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings Panel
  2. Click on 'Pause while Typing' to select
  3. Begin editing the transcript while the audio is playing. Press the 'delete' key once and the player will stop playing. Repeatedly tap the 'delete' key and the editor will get sluggish, then media will start playing again.

Expected behavior
MediaPlayer would not resume play; editing would continue as normal.

Screenshots

Desktop (please complete the following information):

  • OS: macOS Mojave Version 10.14.6
  • Browser Chrome
  • Version 78.0.3904.87 (Official Build) (64-bit)

Additional context

@NickRuiz NickRuiz added the bug Something isn't working label Nov 11, 2019
@NickRuiz NickRuiz changed the title MediaPlayer resumes play when I click the 'delete' button multiple times MediaPlayer resumes play when I click the 'delete' button or arrow buttons multiple times Nov 11, 2019
@pietrop
Copy link
Contributor

pietrop commented Nov 18, 2019

I think this might be because of how the "pause while typing" mechanism work. There is a timer, that pauses the playback, when you start typing, and it resets itself on every key press (draftJs onChange). There's a chance that Increasing that timer might fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants