Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary console.log for speaker block distracting in production #211

Open
pietrop opened this issue Nov 4, 2019 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@pietrop
Copy link
Contributor

pietrop commented Nov 4, 2019

Describe the bug

I forgot to remove a console.log in a previous PR

console.log('componentDidUpdate wrapper speaker', prevProps.block.getData().get('speaker') , prevState.speaker );

To Reproduce
open the demo app, load demo and open inspector

Expected behavior

not to see this console.log for every speaker / paragraph being loaded

Screenshots

NA

Additional context

NA

Might raise a PR if I can find the time, otherwise anybody else welcome to fix this. (it will also need re-publishing on npm, re-deploying github pages demo etc..)

@pietrop pietrop added the bug Something isn't working label Nov 4, 2019
@emettely emettely self-assigned this Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants