Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precision specifier for %f, %g, %G string interpolation formats #232

Open
tetromino opened this issue Oct 5, 2022 · 1 comment
Open

Comments

@tetromino
Copy link
Collaborator

Now that Starlark has gained support for floating point, it makes sense to revisit the decision to not allow width or precision specifiers for % string interpolation formats.

This would be particularly useful for the java implementation of Starlark, where java.util.Formatter's default precision is 6 - meaning "%f" % 2" is currently "2.000000" instead of "2.0".

@brandjon
Copy link
Member

My main concern is whether there are subtle differences possible in a naive implementation e.g. w.r.t. rounding behavior, and how much effort we have to go through to ensure compatibility with Python and across multiple Starlark implementations. But it sounds like a sensible addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants