Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_webtesting is failing with Bazel@HEAD in CI #458

Open
sgowroji opened this issue Jul 14, 2023 · 7 comments
Open

rules_webtesting is failing with Bazel@HEAD in CI #458

sgowroji opened this issue Jul 14, 2023 · 7 comments

Comments

@sgowroji
Copy link
Member

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3165#01895229-4fb7-4ff9-9027-04b0cb372a34

Platform : Ubuntu, MacOS, Windows
Logs :

return java_common.pack_sources(
	File "/virtual_builtins_bzl/common/java/java_common.bzl", line 150, column 68, in _pack_sources
Error in _check_java_toolchain_is_declared_on_rule: Rule 'scala_library_for_plugin_bootstrapping' in '/private/var/tmp/_bazel_buildkite/babcd828cef764fd2f88fc3cf799c018/external/io_bazel_rules_scala/third_party/dependency_analyzer/src/main/BUILD:6:39' must declare '@bazel_tools//tools/jdk:toolchain_type' toolchain in order to use java_common.
(04:24:42) ERROR: /private/var/tmp/_bazel_buildkite/babcd828cef764fd2f88fc3cf799c018/external/io_bazel_rules_scala/third_party/dependency_analyzer/src/main/BUILD:6:39: Analysis of target '@io_bazel_rules_scala//third_party/dependency_analyzer/src/main:scala_version' failed
(04:24:42) ERROR: Analysis of target '//scalatests/com/google/testing/web:WebTestTest_chrome-win10-connect' failed; build aborted: Analysis

Steps:

git clone https://github.com/bazelbuild/rules_webtesting.git 
git reset 9f39b9dd292c763cef44cc63719e399373b17631 --hard
export USE_BAZEL_VERSION=53914865fc26850a1f282a83f3846c6103af217e
bazel build //...

CC Greenteam @SalmaSamy

@sgowroji
Copy link
Member Author

Hi @DrMarcII , Can you please have a look on this issue. Thanks!

@sgowroji
Copy link
Member Author

Hello @DrMarcII or the rules_webtesting team, in case the failures persist without resolution for an extended period, we may need to transition this to the disabled pipeline. It would be greatly appreciated if you could respond and provide us with an update. Thank you!

@DrMarcII
Copy link
Contributor

DrMarcII commented Jul 26, 2023 via email

@mtrea
Copy link
Collaborator

mtrea commented Jul 27, 2023

What's the implication of transitioning to the disabled pipeline? Do you have any idea what the suggested fix is for this issue or what change might be causing it?

@sgowroji
Copy link
Member Author

CC @meteorcloudy

@meteorcloudy
Copy link
Member

What's the implication of transitioning to the disabled pipeline?

@sgowroji meant the downstream pipeline for Bazel@HEAD, check the doc and policy here: https://github.com/bazelbuild/continuous-integration/blob/master/docs/downstream-testing.md

I believe this is the same root cause as bazel-contrib/rules_jvm_external#931, but from the error message, it seems this should be fixed in rules_scala first.

@meteorcloudy
Copy link
Member

@sgowroji No, I meant those two have the same root cause, but should be fixed in both projects. That means a similar change should be made in rules_webtesting (or in rules_scala then update rules_scala in rules_webtesting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants