Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --incompatible_config_setting_private_default_visibility will break rules_webtesting in Bazel 7.0 #446

Open
keertk opened this issue Nov 23, 2022 · 7 comments

Comments

@keertk
Copy link
Member

keertk commented Nov 23, 2022

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_webtesting. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#12933.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

@joshbruning
Copy link
Collaborator

This project is on an old rules_go release; after its deps are updated, I think this will be ok

@joshbruning
Copy link
Collaborator

I tried building with today's rules_go release; however, there will need to also be a new bazel-gazelle (not yet released) due to (at least) bazel-contrib/rules_go#3276

@keertk keertk changed the title Flag --incompatible_config_setting_private_default_visibility will break rules_webtesting in a future Bazel release Flag --incompatible_config_setting_private_default_visibility will break rules_webtesting in Bazel 7.0 Nov 29, 2022
@alexeagle
Copy link
Contributor

@joshbruning hi, are you still a maintainer here? I noticed this issue is 6mo old, I am sure any changes you need from rules_go and bazel-gazelle have been released.

@joshbruning
Copy link
Collaborator

No, I haven't been for some years; @mtrea - I think you should try updating the version set and trying a build at least (it may end up being easy); the version diff is getting bigger, and will eventually make the update more difficult to do in one-shot, and there have been an increasing number of linter headaches

@sgowroji
Copy link
Member

Hi @joshbruning, Could you please look in to this issue.Thanks!

@joshbruning
Copy link
Collaborator

I'm not a maintainer.

@sgowroji
Copy link
Member

@mtrea Can you Please have a look on the above failures. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants