Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Repository Pattern to Toolchain #993

Closed
borkaehw opened this issue Feb 7, 2020 · 4 comments
Closed

Remove Repository Pattern to Toolchain #993

borkaehw opened this issue Feb 7, 2020 · 4 comments

Comments

@borkaehw
Copy link
Contributor

borkaehw commented Feb 7, 2020

Move *_repositories to a toolchain. It includes

  • jmh_repositories
  • junit_repositories
  • scala_repositories
  • scalafmt_repositories
  • scala_proto_repositories
  • specs2_repositories
  • specs2_junit_repositories
  • tut_repositories

I may miss some.

@ittaiz
Copy link
Member

ittaiz commented Feb 8, 2020

Isn’t it a duplicate of #940 ?

@borkaehw
Copy link
Contributor Author

borkaehw commented Feb 8, 2020

That's right, sorry for that. Would you mind to make sure the items I listed are mentioned in #940? Then I will close it.

@ittaiz
Copy link
Member

ittaiz commented Feb 10, 2020

Most are there. scala_repositories isn't there but that's a much larger discussion that's taking place.
junit and specs2_junit aren't there but specs2 is.
Not sure if junit/specs2_junit should be a top level toolchain

@borkaehw
Copy link
Contributor Author

Thanks for making sure. Also make sure scalafmt is there as well. Closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants