Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all_crate_deps doesn't work with bzlmod #2470

Closed
AmeliasCode opened this issue Feb 8, 2024 · 2 comments
Closed

all_crate_deps doesn't work with bzlmod #2470

AmeliasCode opened this issue Feb 8, 2024 · 2 comments

Comments

@AmeliasCode
Copy link
Contributor

When support for third party crates was added for bzlmod, all_crate_deps was left out: #1910

This creates a behavioral difference for rules_rust via bzlmod vs not-bzlmod.
@AmeliasCode
Copy link
Contributor Author

Raised a PR to fix this: #2461

@illicitonion
Copy link
Collaborator

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@illicitonion @AmeliasCode