Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should have test targets #5

Open
jart opened this issue Jul 17, 2016 · 2 comments
Open

Should have test targets #5

jart opened this issue Jul 17, 2016 · 2 comments

Comments

@jart
Copy link
Contributor

jart commented Jul 17, 2016

I've noticed this repository doesn't have any test targets. Consider adding some.

@ekuefler
Copy link
Collaborator

Yeah, I should really do that.

Is there a recommended structure for tests in rules repositories? Scanning over a few of the other ones they look inconsistent in where they put their tests.

@jart
Copy link
Contributor Author

jart commented Jul 22, 2016

I'm not sure if a best practice has been established. But I can share with you what I did with the Closure Rules repository. I put my tests in the following directories:

All tests are implemented as rules. This way Jenkins (ci.bazel.io) will know how to run them. Closure Rules has to use a bunch of private testing rules like file_test to aid with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants