From 9f58706f4bb9bb531cd0fef23b310737d0643f92 Mon Sep 17 00:00:00 2001 From: mollyibot <93746690+mollyibot@users.noreply.github.com> Date: Tue, 7 Jan 2025 14:12:30 -0800 Subject: [PATCH] Update protobuf test to use jssuite from forked files (#636) * Update protobuf test to use jssuite from forked files * Update bazel version * Update protobuf test to use jssuite from forked files * Update protobuf test to use jssuite from forked files and remove usage of assertHTMLEquals * Remove legacy protobuf test * Add back legacy test * Add a blank line at the end of legacy example test * Update legacy test to use forked jsunit and asserts * Update legacy test to use forked jsunit and asserts * Add back require line and remove additional msg.field() --- closure/protobuf/test/BUILD | 6 +++--- closure/protobuf/test/legacy/BUILD | 4 ++-- closure/protobuf/test/legacy/example_test.js | 3 +-- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/closure/protobuf/test/BUILD b/closure/protobuf/test/BUILD index 6883b290a1..ff51492741 100644 --- a/closure/protobuf/test/BUILD +++ b/closure/protobuf/test/BUILD @@ -52,7 +52,7 @@ closure_js_test( ], deps = [ ":foo", - "@com_google_javascript_closure_library//closure/goog/testing:testsuite", + "//closure/testing/library:testsuite", ], ) @@ -95,7 +95,7 @@ closure_js_test( deps = [ ":baz", ":foo", - "@com_google_javascript_closure_library//closure/goog/testing:testsuite", + "//closure/testing/library:testsuite", ], ) @@ -131,6 +131,6 @@ closure_js_test( ], deps = [ ":bat", - "@com_google_javascript_closure_library//closure/goog/testing:testsuite", + "//closure/testing/library:testsuite", ], ) diff --git a/closure/protobuf/test/legacy/BUILD b/closure/protobuf/test/legacy/BUILD index 8c4c3ef5d6..429d36902c 100644 --- a/closure/protobuf/test/legacy/BUILD +++ b/closure/protobuf/test/legacy/BUILD @@ -40,7 +40,7 @@ closure_js_test( srcs = ["example_test.js"], deps = [ ":example_lib", - "@com_google_javascript_closure_library//closure/goog/testing:asserts", - "@com_google_javascript_closure_library//closure/goog/testing:jsunit", + "//closure/testing/library:asserts", + "//closure/testing/library:jsunit", ], ) diff --git a/closure/protobuf/test/legacy/example_test.js b/closure/protobuf/test/legacy/example_test.js index 9029380f18..f95dcb678a 100644 --- a/closure/protobuf/test/legacy/example_test.js +++ b/closure/protobuf/test/legacy/example_test.js @@ -19,6 +19,5 @@ goog.require('io.bazel.rules.closure.protobuf.Example'); function testExample() { var msg = new io.bazel.rules.closure.protobuf.Example('value'); - msg.field(); - assertHTMLEquals('value', msg.field()); + assertEquals('value', msg.field()); }