Enable --experimental_enable_aspect_hints like we do in rules_swift #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
requested review from
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
approved these changes
Jun 3, 2024
luispadron
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was recently enabled in rules_swift (with bazelbuild/rules_swift#1191) and it seems to be required in the next
rules_swiftbump. I saw the failure initially when testing a rules_swift bump in #2418 which was failing with the following error only in the Bazel 6.x configuration as expected (since it's enabled by default on Bazel 7):