From 6a3a36e4b88fc0e9076cb916ee1a900debe213d3 Mon Sep 17 00:00:00 2001
From: Aaron Sky <aaronsky@skyaaron.com>
Date: Fri, 23 Feb 2024 19:17:13 -0500
Subject: [PATCH]  Allow underscores in bundle identifiers (#2411)

---
 apple/internal/bundling_support.bzl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apple/internal/bundling_support.bzl b/apple/internal/bundling_support.bzl
index 30f0dcccb8..0c96222a52 100644
--- a/apple/internal/bundling_support.bzl
+++ b/apple/internal/bundling_support.bzl
@@ -377,7 +377,7 @@ def _validate_bundle_id(bundle_id):
             # handled by the split(), so just have to check for '-'.
             for i in range(len(part)):
                 ch = part[i]
-                if ch != "-" and not ch.isalnum():
+                if ch not in ["-", "_"] and not ch.isalnum():
                     fail("Invalid character(s) in bundle_id: \"%s\"" % bundle_id)
 
 # Define the loadable module that lists the exported symbols in this file.