Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BazelCI has numerous problems #171

Closed
katre opened this issue Oct 20, 2023 · 2 comments
Closed

BazelCI has numerous problems #171

katre opened this issue Oct 20, 2023 · 2 comments

Comments

@katre
Copy link
Member

katre commented Oct 20, 2023

I've been digging into the recent failures in rules_android BazelCI.

There are a number of errors present.

  1. Topmost: rules_android isn't setting the needed flags for Android Platforms
    1. We need to set --incompatible_enable_android_toolchain_resolution to fix this for now, and eventually add the flags
  2. After that: In the tests that disable bzlmod, there's a Bazel error with Java toolchains at head
    1. We can fix this by using Bazel 7.0.0rc1, which was cut before this error was added
  3. After this, several sets of tests do not work:
    1. android_local_test tests are very fragile #169
    2. sandboxedsdktoolbox tests not compatible with bzlmod #170

After we stabilize, we need to add Android Platforms flags.
@katre katre mentioned this issue Oct 20, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Oct 24, 2023
@katre @copybara-github
Just fix CI
f41aaa6 
Trying to deal with #171.

Closes #172.

PiperOrigin-RevId: 576123681
Change-Id: I719482de8c385d4bdec069615f6e403788564aad
@katre
Copy link
Member Author

katre commented Oct 30, 2023

#175 is another example of this.

@katre katre mentioned this issue Oct 30, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Oct 30, 2023
@katre @copybara-github
Split BazelCI tasks into smaller pieces.
90bbf87 
This splits the "tools" and "rules" tasks, because each needs different flags to be applied.

This also disables failing tests, fixing #171. (See https://buildkite.com/bazel/rules-android/builds/2036)

PiperOrigin-RevId: 577853284
Change-Id: I1b62d7b7ef641a1a4431f8f7136a66dc9d9c3c76
@katre
Copy link
Member Author

katre commented Oct 30, 2023

With 90bbf87, CI is green, but all the underlying issues still need to be fixed.

@katre katre closed this as completed Oct 30, 2023
jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
@katre
Just fix CI
4b577ad 
Trying to deal with bazelbuild#171.

Closes bazelbuild#172.

PiperOrigin-RevId: 576123681
Change-Id: I719482de8c385d4bdec069615f6e403788564aad
jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
@katre
Split BazelCI tasks into smaller pieces.
df1be9c 
This splits the "tools" and "rules" tasks, because each needs different flags to be applied.

This also disables failing tests, fixing bazelbuild#171. (See https://buildkite.com/bazel/rules-android/builds/2036)

PiperOrigin-RevId: 577853284
Change-Id: I1b62d7b7ef641a1a4431f8f7136a66dc9d9c3c76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katre