Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_android is at failing at head (using last released Bazel) #134

Closed
sgowroji opened this issue Sep 12, 2023 · 8 comments
Closed

rules_android is at failing at head (using last released Bazel) #134

sgowroji opened this issue Sep 12, 2023 · 8 comments

Comments

@sgowroji
Copy link
Member

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3301#018a8729-3a82-4f9d-94ad-55c9bba5ad9d

Platform : Macos, Ubunut, Windows

Logs

 ERROR: /private/var/tmp/_bazel_buildkite/c20264bbc759d5aac7fdbed934c4ab01/external/io_bazel_rules_go/go/private/context.bzl:556:23: Use of Starlark transition without allowlist attribute '_allowlist_function_transition'. See Starlark transitions documentation for details and usage: @io_bazel_rules_go//go/private:context.bzl NORMAL
(04:18:43) ERROR: Skipping '//src/...': error loading package under directory 'src': error loading package 'src/tools/bundletool_module_builder': at /private/var/tmp/_bazel_buildkite/c20264bbc759d5aac7fdbed934c4ab01/external/io_bazel_rules_go/go/def.bzl:26:5: initialization of module 'go/private/context.bzl' failed
(04:18:43) ERROR: error loading package under directory 'src': error loading package 'src/tools/bundletool_module_builder': at /private/var/tmp/_bazel_buildkite/c20264bbc759d5aac7fdbed934c4ab01/external/io_bazel_rules_go/go/def.bzl:26:5: initialization of module 'go/private/context.bzl' failed

Steps:

git clone https://github.com/bazelbuild/rules_android.git && cd rules_android
git reset 7760d83db7e57961b2d865f75788b3b5f5db6ab8 --hard
export USE_BAZEL_VERSION=07e0d316a345a3cb2593f98525320590bbc56e30
bazel build //src/... //test/... //android/... //rules/... -//src/java/com/example/sampleapp/... //toolchains/... //tools/... -//tools/android/...

Culprit : bazelbuild/bazel@10a46b1

CC Greenteam @meteorcloudy

@comius
Copy link
Collaborator

comius commented Sep 12, 2023

The problem is stale version of rules_go in rules_android.
The version of rules_go is upgraded in rules_android at head, however rules_android build at head is failing (downstream is using last green).

@comius
Copy link
Collaborator

comius commented Sep 12, 2023

At head failure in rules_android: https://buildkite.com/bazel/rules-android/builds/1815#018a86bb-0387-410a-808a-4f798b469479

@comius comius changed the title rules_android is failing at Bazel@HEAD rules_android is at failing at head (using last released Bazel) Sep 12, 2023
@comius
Copy link
Collaborator

comius commented Sep 12, 2023

cc @katre @timpeut

@comius
Copy link
Collaborator

comius commented Sep 12, 2023

cc @lucasvtenorio

@katre
Copy link
Member

katre commented Sep 12, 2023

Looks like several sets of failures:

I'll take a look at the extra_args issue, that might be due to the version of bash being used on macOS. I can also look at the maven issue with bzlmod, probably just something was only added to the WORKSPACE and not to MODULE.bzl.

katre added a commit to katre/rules_android that referenced this issue Sep 12, 2023
Apparently macOS's version of bash doesn't handle empty arrays well.

Part of bazelbuild#134.
copybara-service bot pushed a commit that referenced this issue Sep 12, 2023
Apparently macOS's version of bash doesn't handle empty arrays well.

Part of fixing #134.

PiperOrigin-RevId: 564728459
Change-Id: I38363d52b01f453daf889e8b116dd1a1dc8bfe98
katre added a commit to katre/rules_android that referenced this issue Sep 12, 2023
copybara-service bot pushed a commit that referenced this issue Sep 12, 2023
This fixes macos/arm issues from #134.

PiperOrigin-RevId: 564766222
Change-Id: I3b432d68f1d45f47c360a4834884f4d849d70770
katre added a commit to katre/rules_android that referenced this issue Sep 12, 2023
copybara-service bot pushed a commit that referenced this issue Sep 12, 2023
Part of #134.

PiperOrigin-RevId: 564811140
Change-Id: Ic2645c333f9f5247a1ddb8e90f99e96876d029c9
@katre
Copy link
Member

katre commented Sep 12, 2023

All issues resolved: https://buildkite.com/bazel/rules-android/builds/1823

@katre
Copy link
Member

katre commented Sep 12, 2023

(I;d close this but I don't have permissions)

@ahumesky
Copy link
Collaborator

Thanks all!

jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
Apparently macOS's version of bash doesn't handle empty arrays well.

Part of fixing bazelbuild#134.

PiperOrigin-RevId: 564728459
Change-Id: I38363d52b01f453daf889e8b116dd1a1dc8bfe98
jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
This fixes macos/arm issues from bazelbuild#134.

PiperOrigin-RevId: 564766222
Change-Id: I3b432d68f1d45f47c360a4834884f4d849d70770
jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
Part of bazelbuild#134.

PiperOrigin-RevId: 564811140
Change-Id: Ic2645c333f9f5247a1ddb8e90f99e96876d029c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants