bazelrc: set java_runtime_version for builds too #5836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwse, if the default Java version on the host is "lower" (in my
case, 11), the following happens:
```
$ bazel build //base:integration_tests --define=ij_product=intellij-2023.3
ERROR: /home/motiejus/code/intellij/base/BUILD:535:32: Building base/integration_tests.jar (72 source files) failed: (Exit 1): java failed: error executing Javac command (from target //base:integration_tests) external/remotejdk17_linux/bin/java '--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED' '--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED' ... (remaining 19 arguments skipped)
base/tests/integrationtests/com/google/idea/blaze/base/lang/buildfile/search/GlobalWordIndexTest.java:81: warning: [removal] SERVICE in CacheManager has been deprecated and marked for removal
CacheManager.SERVICE
^
base/tests/integrationtests/com/google/idea/blaze/base/lang/buildfile/references/BuildReferenceManagerTest.java:47: error: cannot find symbol
.toList();
^
symbol: method toList()
location: interface Stream<String>
base/tests/integrationtests/com/google/idea/blaze/base/lang/buildfile/references/BuildReferenceManagerTest.java:68: error: cannot find symbol
.toList();
^
symbol: method toList()
location: interface Stream<String>
Use --verbose_failures to see the command lines of failed build steps.
```
However, `bazel test` with the same arguments succeeds.
The current behaviour is "technically" correct, but is a confusing: we
should be able to build our tests, not only run them.
Fixes #5835
ghost
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sgowroji
added
product: IntelliJ
mai93
approved these changes
Dec 19, 2023
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the default Java version on the host is "lower" (in my case, 11), the following happens on master:
The current behaviour is "technically" correct, because
bazel testsucceeds. However, it is very confusing: we should be able to build our tests, not only run them.Fixes #5835
Checklist
Discussion thread for this change
Issue number: #5835