Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google tests can't be debug in v2024.08.13-stable in CLion 2024.2 #6740

Closed
ujohnny opened this issue Sep 6, 2024 · 1 comment
Closed

Google tests can't be debug in v2024.08.13-stable in CLion 2024.2 #6740

ujohnny opened this issue Sep 6, 2024 · 1 comment
Assignees
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: CLion CLion plugin type: bug

Comments

@ujohnny
Copy link
Collaborator

ujohnny commented Sep 6, 2024

Description of the bug:

2024-09-05 20:38:10,595 [172591363]   INFO - #c.i.e.r.ExecutionUtil - Error running 'Bazel test ExprVariantEnforceLengthTest.smallLength (ExprVariantEnforceLengthTest.cpp)':<br>Access is allowed from Event Dispatch Thread (EDT) only; see https://jb.gg/ij-platform-threading for details
Current thread: Thread[#2573,DefaultDispatcher-worker-7,6,main] 929198670 (EventQueue.isDispatchThread()=false)
SystemEventQueueThread: Thread[#46,AWT-EventQueue-0,6,main] 620482553
com.intellij.openapi.diagnostic.RuntimeExceptionWithAttachments: Access is allowed from Event Dispatch Thread (EDT) only; see https://jb.gg/ij-platform-threading for details
Current thread: Thread[#2573,DefaultDispatcher-worker-7,6,main] 929198670 (EventQueue.isDispatchThread()=false)

Which category does this issue belong to?

No response

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which Intellij IDE are you using? Please provide the specific version.

CLion 2024.2

What programming languages and tools are you using? Please provide specific versions.

No response

What Bazel plugin version are you using?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@ujohnny ujohnny added type: bug awaiting-maintainer Awaiting review from Bazel team on issues labels Sep 6, 2024
@ujohnny ujohnny self-assigned this Sep 6, 2024
@sgowroji sgowroji added the product: CLion CLion plugin label Sep 6, 2024
@ujohnny
Copy link
Collaborator Author

ujohnny commented Sep 6, 2024

the workaround

  1. open .clwb/.idea/workspace.xml
  2. find section <component name="PropertiesComponent"><![CDATA[{
  3. add "bazel.test_filter.googletest_update": "true", to the dictionary there

ujohnny added a commit to ujohnny/intellij that referenced this issue Sep 6, 2024
after 2024.2 CLion invokes createProcess on a background
thread, so UI access is no longer allowed in this context.
fix is backward compatible as we're allowed to use
invokeAndWait on EDT as well.

fixes bazelbuild#6740
ujohnny added a commit to ujohnny/intellij that referenced this issue Sep 6, 2024
after 2024.2 CLion invokes createProcess on a background
thread, so UI access is no longer allowed in this context.
fix is backward compatible as we're allowed to use
invokeAndWait on EDT as well.

fixes bazelbuild#6740
@ujohnny ujohnny closed this as completed in c616753 Sep 6, 2024
mai93 pushed a commit that referenced this issue Sep 6, 2024
* clion: fix UI call on non-UI thread

after 2024.2 CLion invokes createProcess on a background
thread, so UI access is no longer allowed in this context.
fix is backward compatible as we're allowed to use
invokeAndWait on EDT as well.

fixes #6740

* clion: add missing ReadActions to GoogleTest support

since the code was moved from the UI thread to the
background,the read action context is no longer available.
anyway in CLion 2024.3 this will be broken since ijplatform
will not be providing implicit read action context on EDT.

(cherry picked from commit c616753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: CLion CLion plugin type: bug
Projects
None yet
Development

No branches or pull requests

4 participants