Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect status of Bazel sync run in UI #5779

Open
dkashyn-sfdc opened this issue Nov 27, 2023 · 2 comments
Open

Incorrect status of Bazel sync run in UI #5779

dkashyn-sfdc opened this issue Nov 27, 2023 · 2 comments
Assignees
Labels
awaiting-maintainer Awaiting review from Bazel team on issues lang: java Java rules integration P3 We're not considering working on this, but happy to review a PR. (No assignee) product: IntelliJ IntelliJ plugin topic: sync Issues related to the sync operation type: bug

Comments

@dkashyn-sfdc
Copy link
Contributor

dkashyn-sfdc commented Nov 27, 2023

Description of the bug:

image The build has failed yet Bazel tool window showing that there are no issues

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Protobufs compilation on OSX with XCode missing is the simplest way to repro

ERROR: ..../external/local_config_apple_cc/BUILD:79:24: in cc_toolchain_config rule @@local_config_apple_cc//:darwin_arm64: 
Traceback (most recent call last):
	File "........./external/local_config_apple_cc/cc_toolchain_config.bzl", line 2465, column 58, in _impl
		enabled = xcode_support.is_xcode_at_least_version(xcode_config, "15.0.0"),
	File "......../external/build_bazel_apple_support/lib/xcode_support.bzl", line 35, column 13, in _is_xcode_at_least_version
		fail("Could not determine Xcode version at all. This likely means Xcode isn't available; " +
Error in fail: Could not determine Xcode version at all. This likely means Xcode isn't available; if you think this is a mistake, please file an issue.
ERROR: ....../external/local_config_apple_cc/BUILD:79:24: Analysis of target '@@local_config_apple_cc//:darwin_arm64' failed
Analyzing: 64 targets (1502 packages loaded, 178522 targets configured)

Which Intellij IDE are you using? Please provide the specific version.

2023.3

What programming languages and tools are you using? Please provide specific versions.

Java

What Bazel plugin version are you using?

Bazel 7.0.0-rc4 with 'master` of IJWB

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@dkashyn-sfdc dkashyn-sfdc added awaiting-maintainer Awaiting review from Bazel team on issues type: bug labels Nov 27, 2023
@iancha1992 iancha1992 added product: IntelliJ IntelliJ plugin lang: java Java rules integration topic: sync Issues related to the sync operation labels Nov 27, 2023
@tpasternak
Copy link
Contributor

I'm not sure, but it looks like it works as intended from the beginning. The plugin considers "sync" to be successful even if "build" has failed. That's why it prints

Sync was successful, but there were Bazel build errors. The project may not be fully updated or resolve until fixed. If the errors are from your working set, please uncheck 'Bazel > Sync > Expand Sync to Working Set' and try again.

But I agree we could make it more visible to the users

@tpasternak tpasternak added the P3 We're not considering working on this, but happy to review a PR. (No assignee) label Nov 29, 2023
@dkashyn-sfdc
Copy link
Contributor Author

It can be at least warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-maintainer Awaiting review from Bazel team on issues lang: java Java rules integration P3 We're not considering working on this, but happy to review a PR. (No assignee) product: IntelliJ IntelliJ plugin topic: sync Issues related to the sync operation type: bug
Projects
Status: Untriaged
Development

No branches or pull requests

5 participants