-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Illegal Character" trying to debug go_test, and passing tests don't show up when run. #3555
Comments
For a comparison, I also checked with IntelliJ for my java tests (same bazel plugin version) and it worked fine there, so it does seem to be golang specific. |
Further note: I tried adding a |
Hello @bdleitner, Could you please respond if you are looking support for the above issue and also provide a sample code to verify the same. Thanks! |
Sorry for the delayed response. Yes, I'm still looking for support if it's
still happening. I didn't have a chance to test it out this weekend.
I will try and repro this evening or next after seeing if there are any
updates and I'll post a repo to github with a minimal reproducible example.
But when last I checked it was happening for all tests I tried to debug.
Literally a dummy setup of "here's a method that returns 1" and "here's a
test that verifies it returns 1" (to pass) or "here's a method that
verifies it returns 2" (to fail) had the problem.
…On Mon, Oct 17, 2022 at 1:00 AM Gowroji Sunil ***@***.***> wrote:
Hello @bdleitner <https://github.com/bdleitner>, Could you please respond
if you are looking support for the above issue and also provide a sample
code to verify the above issue. Thanks!
—
Reply to this email directly, view it on GitHub
<#3555 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZKXDTQB2PXIY46RCIEAH3WDUBR7ANCNFSM5U2I6J7Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Rechecked with updated Bazel plugin and confirmed the issue still occurs. |
Thank you for contributing to the IntelliJ repository! This issue has been marked as stale since it has not had any activity in the last 6 months. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-maintainer". Please reach out to the triage team ( |
When I updated he plugin to the 08.29- version, I could no longer reproduce this. It appears this has been fixed. |
Yes, this was fixed a while ago. Sorry for not communicating! |
I just ran into this again in Goland 2024.2.1.1 with bazel plugin version 2024.08.27.0.1-api-version-242 |
@bdleitner sorry, I was OOO last week, do you use testify, by any chance? |
On Wed, Sep 25, 2024 at 5:03 AM Tomasz Pasternak ***@***.***> wrote:
@bdleitner <https://github.com/bdleitner> sorry, I was OOO last week, do
you use testify, by any chance?
I do not (not familiar with it).
… —
Reply to this email directly, view it on GitHub
<#3555 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZKXDRY6RTAMS6NU2FK3M3ZYKRB5AVCNFSM6AAAAABOHQGXBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZTHA4TAMZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Note sure if it's related, I tried doing "run test with coverage" and got:
|
Honestly I think there is an error in the rules you use, and therefore no tests are actually run |
Seems that one of the actions declares an output, but fails to create it |
Yeah, run with coverage doesn't seem to work because the coverage isn't generated. Seems unrelated to the illegal char issue. |
can I close the ticket then? |
The thing about coverage not working was an aside that I thought at first
might be related. It seems not to be, but the last time I tried anything
the illegal character issue on trying to debug tests was still active.
I should have kept the coverage thing separate; sorry for the confusion.
…On Tue, Oct 8, 2024, 09:08 Tomasz Pasternak ***@***.***> wrote:
can I close the ticket then?
—
Reply to this email directly, view it on GitHub
<#3555 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZKXDQX6X4P3RTJDCPFSS3Z2P7OZAVCNFSM6AAAAABOHQGXBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGI2TQMBRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
So may I ask you to open a new issue with a repro? |
Wait... Is the illegal character issue fixed? Do you know when the fix will
go out?
I mentioned another problem I ran into on this bug, thinking at first it
might be connected. As it turns out, it's not. I can file a separate issue
for that with more information for a repro, bit that has nothing to do with
the illegal character bug, so unless that issue is fixed, this should stay
open.
…On Tue, Oct 8, 2024, 10:30 Tomasz Pasternak ***@***.***> wrote:
So may I ask you to open a new issue with a repro?
—
Reply to this email directly, view it on GitHub
<#3555 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZKXDRZ5C3C6VOEPTQRH5TZ2QJD7AVCNFSM6AAAAABOHQGXBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGQ2DCMBXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
oh, misunderstood you |
may I ask you to provide a minimal repro, then? |
I've updated my repro at https://github.com/bdleitner/illegal_char_demo to use bzlmod like my other big repo where I'm having the issue, and updated the screenshots. |
The problem occurs when run a test in Goland from the "Run/Debug configurations" using bazel test.
If I just run, then the tests run and I can see the results on the console, but the test navigator says "No tests were found" (if they all pass)
Note that I have "show passing tests" selected, so the passing tests are expected to show up.
Interestingly, if I change one of the tests to fail, I get...
so the failing test shows up and the passing ones do not.
But the original issue I had is that I'm not able to debug. If I click the debug button I get:
I tried upgrading the bazel plugin (and Goland) since I saw that fixing debugging with
go_test
was on the list of recent fixes, but the issue persists after all of that, plus doingbazel clean
and even nuking my output-user-root directory to force everything to rebuild.Also note that the illegal character remains at index 116 even if I change the test to have everything commented out, leaving only one empty test method.
Throughout all of this,
bazel build
andbazel test
continue to work from the terminal as expected.Versions:
Goland: 2022.1
Bazelisk: 1.11.0
Bazel: 5.1.1
Bazel Plugin: 2022.04.28.0.0-api-version-221
The text was updated successfully, but these errors were encountered: