diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/CcRules.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/CcRules.java index d3caf54cc5a59f..e6a83553cf43e2 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/CcRules.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/rules/CcRules.java @@ -113,7 +113,7 @@ public void init(ConfiguredRuleClassProvider.Builder builder) { builder.addStarlarkBuiltinsInternal("MemProfProfileInfo", MemProfProfileProvider.PROVIDER); builder.addStarlarkBuiltinsInternal( "PackageSpecificationInfo", PackageGroupConfiguredTarget.PROVIDER); - builder.addStarlarkBuiltinsInternal("cc_common_internal_do_not_use", bazelCcModule); + builder.addStarlarkBuiltinsInternal("cc_common", bazelCcModule); builder.addStarlarkBootstrap( new CcBootstrap( bazelCcModule, diff --git a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/BazelCcModuleApi.java b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/BazelCcModuleApi.java index f3be3c610f8a32..b634f2f2e29601 100644 --- a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/BazelCcModuleApi.java +++ b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/BazelCcModuleApi.java @@ -23,7 +23,7 @@ /** Utilites related to C++ support. */ @StarlarkBuiltin( - name = "cc_common_internal_do_not_use", + name = "cc_common", category = DocCategory.TOP_LEVEL_MODULE, doc = "Utilities for C++ compilation, linking, and command line generation.") public interface BazelCcModuleApi< diff --git a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/CcModuleApi.java b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/CcModuleApi.java index 3b593472395cc2..df67b8e9ce5a58 100755 --- a/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/CcModuleApi.java +++ b/src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/CcModuleApi.java @@ -39,7 +39,7 @@ /** Utilites related to C++ support. */ @StarlarkBuiltin( - name = "cc_common_internal_do_not_use", + name = "cc_common", category = DocCategory.TOP_LEVEL_MODULE, doc = "Utilities for C++ compilation, linking, and command line generation.") public interface CcModuleApi< diff --git a/src/main/starlark/builtins_bzl/common/cc/cc_common.bzl b/src/main/starlark/builtins_bzl/common/cc/cc_common.bzl index 2291c46fffb36e..88f2b2661868a3 100644 --- a/src/main/starlark/builtins_bzl/common/cc/cc_common.bzl +++ b/src/main/starlark/builtins_bzl/common/cc/cc_common.bzl @@ -17,7 +17,7 @@ load(":common/cc/cc_info.bzl", "CcInfo") load(":common/cc/cc_shared_library_hint_info.bzl", "CcSharedLibraryHintInfo") -cc_common_internal = _builtins.internal.cc_common_internal_do_not_use +cc_common_internal = _builtins.internal.cc_common CcNativeLibraryInfo = _builtins.internal.CcNativeLibraryInfo # buildifier: disable=name-conventions diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/StarlarkCcCommonTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/StarlarkCcCommonTest.java index 693d51b30730d9..dce39ff26a6292 100755 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/StarlarkCcCommonTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/StarlarkCcCommonTest.java @@ -8136,7 +8136,7 @@ public void testCheckPrivateApiCanOnlyBeCalledFromCcCommonBzl() throws Exception scratch.file( "foo/custom_rule.bzl", "def _impl(ctx):", - " cc_common_internal_do_not_use.check_private_api(allowlist = [])", + " cc_common.check_private_api(allowlist = [])", " return []", "custom_rule = rule(", " implementation = _impl,", @@ -8145,7 +8145,7 @@ public void testCheckPrivateApiCanOnlyBeCalledFromCcCommonBzl() throws Exception AssertionError e = assertThrows(AssertionError.class, () -> getConfiguredTarget("//foo:custom")); - assertThat(e).hasMessageThat().contains("name 'cc_common_internal_do_not_use' is not defined"); + assertThat(e).hasMessageThat().contains("'struct' value has no field or method 'check_private_api'"); } @Test