-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version resolution in AutoloadSymbols
#23936
Conversation
The logic picked the first instead of the highest version due to a typo.
@bazel-io flag |
@cushon FYI, IntelliJ flagged this, but I wonder whether there is an errorprone check for it that could have prevented this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thanks!!
Not sure how hard it would be to add a test for this? |
I don't think we have one, but it's a good idea, I filed a FR |
@bazel-io fork 8.0.0 |
The logic picked the first instead of the highest version due to a typo. Closes bazelbuild#23936. PiperOrigin-RevId: 684528776 Change-Id: Ic61c84ca2f3489e43fc71944824e7e2311543ab9
@bazel-io fork 7.4.0 |
The logic picked the first instead of the highest version due to a typo. Closes #23936. PiperOrigin-RevId: 684528776 Change-Id: Ic61c84ca2f3489e43fc71944824e7e2311543ab9 Commit 4e6a28a Co-authored-by: Fabian Meumertzheim <[email protected]>
The logic picked the first instead of the highest version due to a typo. Closes bazelbuild#23936. PiperOrigin-RevId: 684528776 Change-Id: Ic61c84ca2f3489e43fc71944824e7e2311543ab9
The logic picked the first instead of the highest version due to a typo. Closes #23936. PiperOrigin-RevId: 684528776 Change-Id: Ic61c84ca2f3489e43fc71944824e7e2311543ab9 Co-authored-by: Fabian Meumertzheim <[email protected]>
The logic picked the first instead of the highest version due to a typo.