-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cc_library.additional_compiler_inputs should be subject to $(location ...)
substitution
#23885
Comments
i think this is what you want? #23102 |
If you can do I am not seeing a test for both? But I don't know what the difference is. |
we're not adding it to defines, related quote from that thread:
|
Oh, so |
Fixes bazelbuild#23885 Closes bazelbuild#23102. PiperOrigin-RevId: 684433748 Change-Id: I12cdb9a04f930a52e57bbd8551c8f2559a15932a
Fixes bazelbuild#23885 Closes bazelbuild#23102. PiperOrigin-RevId: 684433748 Change-Id: I12cdb9a04f930a52e57bbd8551c8f2559a15932a
…es (#23939) Fixes #23885 Closes #23102. PiperOrigin-RevId: 684433748 Change-Id: I12cdb9a04f930a52e57bbd8551c8f2559a15932a Commit c2d316b Co-authored-by: Keith Smiley <[email protected]>
…es (#23940) Fixes #23885 Closes #23102. PiperOrigin-RevId: 684433748 Change-Id: I12cdb9a04f930a52e57bbd8551c8f2559a15932a Commit c2d316b Co-authored-by: Keith Smiley <[email protected]>
A fix for this issue has been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Description of the feature request:
Consider the following situation. I'm trying to compile libfst from https://github.com/gtkwave/gtkwave/tree/master/lib/libfst
Now, someone had the great idea to do
#include FST_CONFIG_INCLUDE
in fstapi.c here: https://github.com/gtkwave/gtkwave/blob/master/lib/libfst/fstapi.c#L41This, of course, conflicts with bazel's idea about file placement. I added the file
config.h
, but it wouldn't go into eithersrcs
orhdrs
of the target:libfst
below:I wanted to define
FST_CONFIG_INCLUDE=\\"$(location :config)\\"
, but this would not do becauseadditional_compiler_inputs
is not subject to$(location ...)
substitution apparently. Placing the file elsewhere, e.g. in deps would allow it, but since deps requiresCCInfo
or some such, then I can't place the filegroup there. The:config
target can not be acc_library
since that leads to:Which category does this issue belong to?
No response
What underlying problem are you trying to solve with this feature?
I want to refer to a
$(location)
in acc_library.defines
.Which operating system are you running Bazel on?
Linux. I don't think that maters.
What is the output of
bazel info release
?╰─>$ bazel info release release 7.3.0
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse HEAD
?No response
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
No response
The text was updated successfully, but these errors were encountered: