Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More control around --keep_going #23848

Open
peakschris opened this issue Oct 2, 2024 · 2 comments
Open

More control around --keep_going #23848

peakschris opened this issue Oct 2, 2024 · 2 comments
Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc type: bug untriaged

Comments

@peakschris
Copy link

Description of the bug:

We use --keep_going to collect a full set of errors that can be fixed in one go. --keep_going could be improved to allow this set of issues to be collected better:

  • Allow a max errors limit to be supplied - after reaching this number of failing targets, stop.

This would allow a good set of failing targets to be collected, whilst not allowing a large monorepo build with some systemic issue to spend a long time failing everything.

Which category does this issue belong to?

Core

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

windows

What is the output of bazel info release?

7.3.1

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@github-actions github-actions bot added the team-Core Skyframe, bazel query, BEP, options parsing, bazelrc label Oct 2, 2024
@iancha1992 iancha1992 added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed team-Core Skyframe, bazel query, BEP, options parsing, bazelrc labels Oct 2, 2024
@iancha1992
Copy link
Member

@fmeum is this related to #23828?

@fmeum
Copy link
Collaborator

fmeum commented Oct 3, 2024

@iancha1992 It's not. I would guess it's Team-Core.

@iancha1992 iancha1992 added team-Core Skyframe, bazel query, BEP, options parsing, bazelrc and removed team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc type: bug untriaged
Projects
None yet
Development

No branches or pull requests

5 participants