-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if zip
is missing, test-setup.sh summarily deletes undeclared outputs.
#23479
Labels
Comments
github-actions
bot
added
the
team-Core
Skyframe, bazel query, BEP, options parsing, bazelrc
label
Aug 30, 2024
iancha1992
added
team-Local-Exec
Issues and PRs for the Execution (Local) team
and removed
team-Core
Skyframe, bazel query, BEP, options parsing, bazelrc
labels
Aug 30, 2024
Thanks for taking care of this! |
@bazel-io fork 7.4.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this issue
Sep 4, 2024
…iled. Fixes bazelbuild#23479. PiperOrigin-RevId: 670894294 Change-Id: I40319db72123358770a56d217dafb4fc7fd0d467
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 4, 2024
…`zip` failed. (#23510) Fixes #23479. PiperOrigin-RevId: 670894294 Change-Id: I40319db72123358770a56d217dafb4fc7fd0d467 Commit 24d165e Co-authored-by: Googler <[email protected]>
A fix for this issue has been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug:
If
zip
is missing, test-setup.sh summarily deletes undeclared outputs. See also #13230.Since commit 8e639df , test-setup.sh will delete all undeclared outputs when
zip
is unavailable.Which category does this issue belong to?
Core
What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
On ubuntu, just
apt remove zip
, and run any test that emits undeclared outputs. After the test completes, the outputs will be gone.Which operating system are you running Bazel on?
Ubuntu 22 and 24.
What is the output of
bazel info release
?release 7.2.1
If
bazel info release
returnsdevelopment version
or(@non-git)
, tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse HEAD
?No response
If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.
8e639df
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
Not directly relevant, but I find it somewhat troubling that a long and complicated script like test-setup.sh doesn't use basic bash error checking, such as
set -eu -o pipefail
.The text was updated successfully, but these errors were encountered: