makes ICMP works under fakeroot #23411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
network namespace reset /proc/sys/net/ipv4/ping_group_range to default value 1 0, which can't map to valid gid, prevent IPPPROTO_ICMP to work. fix this by written valid gid 0 0, only possible for fakeroot. podman has similar process https://github.com/containers/common/blob/ae4a61e1b2e0af84a668f87f7622d86ebc418cba/pkg/config/containers.conf#L80
github-actions
bot
added
the
awaiting-review
iancha1992
added
the
team-Local-Exec
tjgq
approved these changes
Aug 26, 2024
|
Importing. |
|
@bazel-io fork 7.4.0 |
github-actions
bot
removed
the
awaiting-review
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Aug 27, 2024
See discussion in bazelbuild#23275. Fixes bazelbuild#23275. Fixes bazelbuild#23411. PiperOrigin-RevId: 667906233 Change-Id: Id6dbaeca015297d1c70339f1e2ccdf2db20e0de7
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
See discussion in #23275. Fixes #23275. Fixes #23411. PiperOrigin-RevId: 667906233 Change-Id: Id6dbaeca015297d1c70339f1e2ccdf2db20e0de7 Commit e88a7d9 Co-authored-by: xinyu.wang <[email protected]>
|
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network namespace reset /proc/sys/net/ipv4/ping_group_range to default value 1 0, which can't map to valid gid, prevent IPPPROTO_ICMP to work. fix this by written valid gid 0 0, only possible for fakeroot. podman has similar process https://github.com/containers/common/blob/ae4a61e1b2e0af84a668f87f7622d86ebc418cba/pkg/config/containers.conf#L80
detail information here #23275