Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_repo should be called use_repos #17146

Closed
fmeum opened this issue Jan 5, 2023 · 3 comments
Closed

use_repo should be called use_repos #17146

fmeum opened this issue Jan 5, 2023 · 3 comments
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@fmeum
Copy link
Collaborator

fmeum commented Jan 5, 2023

Description of the bug:

The name use_repo doesn't make it clear that the function accepts an arbitrary number of arguments. There are examples of BCR modules with successive, repeated use_repo calls with a single repo name for the same extension proxy, so this is already providing incorrect intuition to real users.

The singular form is also inconsistent with other API such as register_toolchains and register_execution_platforms.

Since there are only ~40 modules today, many of which don't even use use_repo, adding use_repos and keeping use_repo as a deprecated alias for the time being may be doable. Given that this new function will (hopefully) stay with us for a long time, it may very well be worth the effort.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

Any

What is the output of bazel info release?

6.0.0

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 5, 2023

Another reason for I want to bring this up for discussion is the potential to extend the scope of use_repo (#17141 (comment)), in which case use_repos would be a much more fitting name than use_repo.

@ShreeM01 ShreeM01 added type: bug team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged labels Jan 5, 2023
@Wyverald Wyverald added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) area-Bzlmod Bzlmod-specific PRs, issues, and feature requests and removed untriaged labels Jan 17, 2023
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 30 days. It will be closed in the next 7 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler".

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 17, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Development

No branches or pull requests

3 participants