We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using zstd_cli from the registry module, it appears threading options are disabled.
For example:
bazel run @zstd//:zstd_cli -- --help
Does not show help for the -T# option or other threading related options. Compressing with -T0 does not affect the compression performances.
-T#
-T0
Development (host) and target OS/architectures: Linux / x86_64
Output of bazel --version: bazel 7.4.0
bazel --version
bazel 7.4.0
Version of relevant rules from the WORKSPACE or MODULE.bazel file: bazel_dep(name = "zstd", version = "1.5.6", dev_dependency = True)
WORKSPACE
MODULE.bazel
bazel_dep(name = "zstd", version = "1.5.6", dev_dependency = True)
Language(s) and/or frameworks involved: N/A
No response
I believe this can be fixed by adding local_defines = [ "ZSTD_MULTITHREAD" ] to the zstd_cli rule: https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/zstd/1.5.6/patches/add_build_file.patch#L77
local_defines = [ "ZSTD_MULTITHREAD" ]
zstd_cli
The text was updated successfully, but these errors were encountered:
No branches or pull requests
What happened?
When using zstd_cli from the registry module, it appears threading options are disabled.
For example:
Does not show help for the
-T#
option or other threading related options. Compressing with-T0
does not affect the compression performances.Version
Development (host) and target OS/architectures: Linux / x86_64
Output of
bazel --version
:bazel 7.4.0
Version of relevant rules from the
WORKSPACE
orMODULE.bazel
file:bazel_dep(name = "zstd", version = "1.5.6", dev_dependency = True)
Language(s) and/or frameworks involved: N/A
How to reproduce
No response
Any other information?
I believe this can be fixed by adding
local_defines = [ "ZSTD_MULTITHREAD" ]
to thezstd_cli
rule: https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/zstd/1.5.6/patches/add_build_file.patch#L77The text was updated successfully, but these errors were encountered: