Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: zstd_cli does not have parallelism enabled #3367

Open
gergondet-woven opened this issue Dec 10, 2024 · 0 comments
Open

[Bug]: zstd_cli does not have parallelism enabled #3367

gergondet-woven opened this issue Dec 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gergondet-woven
Copy link

What happened?

When using zstd_cli from the registry module, it appears threading options are disabled.

For example:

bazel run @zstd//:zstd_cli -- --help

Does not show help for the -T# option or other threading related options. Compressing with -T0 does not affect the compression performances.

Version

Development (host) and target OS/architectures: Linux / x86_64

Output of bazel --version: bazel 7.4.0

Version of relevant rules from the WORKSPACE or MODULE.bazel file: bazel_dep(name = "zstd", version = "1.5.6", dev_dependency = True)

Language(s) and/or frameworks involved: N/A

How to reproduce

No response

Any other information?

I believe this can be fixed by adding local_defines = [ "ZSTD_MULTITHREAD" ] to the zstd_cli rule: https://github.com/bazelbuild/bazel-central-registry/blob/main/modules/zstd/1.5.6/patches/add_build_file.patch#L77

@gergondet-woven gergondet-woven added the bug Something isn't working label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant