Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include task-specific shell commands and build flags #46

Open
joeleba opened this issue Jun 28, 2019 · 0 comments
Open

Include task-specific shell commands and build flags #46

joeleba opened this issue Jun 28, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request P2

Comments

@joeleba
Copy link
Member

joeleba commented Jun 28, 2019

Description of the problem / feature request:

For example: https://github.com/bazelbuild/bazel/blob/master/.bazelci/postsubmit.yml#L119

ubuntu1804_javabase9:
    platform: ubuntu1804_nojava
    name: ":java: OpenJDK 9 Javabase"
    shell_commands:
      - sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
        android_ndk_repository/android_ndk_repository/' WORKSPACE
      - rm -f WORKSPACE.bak
    build_flags:
      - "--javabase=@openjdk9_linux_archive//:runtime"
...
ubuntu1804_javabase10:
    platform: ubuntu1804_nojava
    name: ":java: OpenJDK 10 Javabase"
    shell_commands:
      - sed -i.bak -e 's/^# android_sdk_repository/android_sdk_repository/' -e 's/^#
        android_ndk_repository/android_ndk_repository/' WORKSPACE
      - rm -f WORKSPACE.bak
    build_flags:
      - "--javabase=@openjdk10_linux_archive//:runtime"

The same ubuntu1804_nojava platform can have many tasks based on it, each with a different set of shell_commands and build_flags.

It's useful to perform benchmarking on each of these different environments.

@joeleba joeleba added the P2 label Jun 28, 2019
@joeleba joeleba self-assigned this Jun 28, 2019
@joeleba joeleba added the enhancement New feature or request label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2
Projects
None yet
Development

No branches or pull requests

1 participant