-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkstyle tests don't work with a generated checkstyle.xml #226
Comments
illicitonion
added a commit
to illicitonion/rules_jvm
that referenced
this issue
Jan 3, 2024
Thanks for the really clear minimal repro! This should be fixed by #227 |
illicitonion
added a commit
to illicitonion/rules_jvm
that referenced
this issue
Jan 3, 2024
illicitonion
added a commit
that referenced
this issue
Jan 3, 2024
Wow thanks for the turnaround on that @illicitonion ! I just tested it out on my larger repo and everything appears to be working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am trying to run checkstyle tests with a generated
checkstyle.xml
instead of a file in the source tree. It seems like there is something wrong with the rule that isn't allowing this use case.I wrote a minimal reproducible example and pushed it to a repo here: https://github.com/vinnybod/bazel_java_example/tree/generated-checkstyle-config
For the minimal reproduction, the macro just copies the checkstyle config from the source tree into the
bazel-out
runfiles and the label of that genrule is what gets passed into thecheckstyle_config
.The text was updated successfully, but these errors were encountered: