From ab743d5b6b2db875efd6e6078bf60cbce96a9bdb Mon Sep 17 00:00:00 2001 From: Daniel Wagner-Hall Date: Fri, 3 May 2024 11:25:41 +0100 Subject: [PATCH] Fix slashes in srcs --- java/gazelle/generate.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/java/gazelle/generate.go b/java/gazelle/generate.go index 0467c9de..6f9a9e4b 100644 --- a/java/gazelle/generate.go +++ b/java/gazelle/generate.go @@ -548,7 +548,7 @@ func (l javaLang) generateJavaTest(file *rule.File, pathToPackageRelativeToBazel } path := strings.TrimPrefix(f.pathRelativeToBazelWorkspaceRoot, pathToPackageRelativeToBazelWorkspace+"/") - r.SetAttr("srcs", []string{path}) + r.SetAttr("srcs", []string{filepath.ToSlash(path)}) r.SetAttr("test_class", fullyQualifiedTestClass) r.SetPrivateAttr(packagesKey, []types.ResolvableJavaPackage{*types.NewResolvableJavaPackage(f.pkg, true, false)}) @@ -601,7 +601,11 @@ var junit5RuntimeDeps = []string{ func (l javaLang) generateJavaTestSuite(file *rule.File, name string, srcs []string, packageNames *sorted_set.SortedSet[types.PackageName], mavenRepositoryName string, imports *sorted_set.SortedSet[types.PackageName], customTestSuffixes *[]string, hasHelpers bool, res *language.GenerateResult) { const ruleKind = "java_test_suite" r := rule.NewRule(ruleKind, name) - r.SetAttr("srcs", srcs) + slashSrcs := make([]string, 0, len(srcs)) + for _, src := range srcs { + slashSrcs = append(slashSrcs, filepath.ToSlash(src)) + } + r.SetAttr("srcs", slashSrcs) resolvablePackages := make([]types.ResolvableJavaPackage, 0, packageNames.Len()) if hasHelpers { for _, packageName := range packageNames.SortedSlice() {