Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on windows due to issues in bazel-starlib #330

Open
peakschris opened this issue Jun 28, 2024 · 0 comments
Open

Tests fail on windows due to issues in bazel-starlib #330

peakschris opened this issue Jun 28, 2024 · 0 comments

Comments

@peakschris
Copy link
Contributor

peakschris commented Jun 28, 2024 •
edited
Loading

Around 16 test cases are failing with the error below. The root cause is cgrindel/bazel-starlib#447. There is a possible fix: cgrindel/bazel-starlib#446

ERROR: src/main/native/windows/process.cc(202): CreateProcessW("D:\udu\b\n2fuxwdi\execroot\_main\bazel-out\x64_windows-fastbuild\bin\bazel_integration_test\private\bzlformat_lint_test.sh.runfiles\_main\bazel_integration_test\private\bzlformat_lint_test.sh"): %1 is not a valid Win32 application

Full message:

INFO: From Testing //bazel_integration_test/private:bzlformat_lint_test:
==================== Test output for //bazel_integration_test/private:bzlformat_lint_test:
ERROR(tools/test/windows/tw.cc:1302) ERROR: src/main/native/windows/process.cc(202): CreateProcessW("D:\udu\b\n2fuxwdi\execroot\_main\bazel-out\x64_windows-fastbuild\bin\bazel_integration_test\private\bzlformat_lint_test.sh.runfiles\_main\bazel_integration_test\private\bzlformat_lint_test.sh"): %1 is not a valid Win32 application.
 (error: 193)
ERROR(tools/test/windows/tw.cc:1479) Failed to start test process (arg: D:\udu\b\n2fuxwdi\execroot\_main\bazel-out\x64_windows-fastbuild\bin\bazel_integration_test\private\bzlformat_lint_test.sh.runfiles\_main\bazel_integration_test\private\bzlformat_lint_test.sh)
================================================================================

To reproduce:

git clone
cd rules_bazel_integration_test
bazel test //tests/tools_tests:bzlformat_lint_test
bazel clean
bazel --windows_enable_symlinks test //tests/tools_tests:bzlformat_lint_test
bazel clean
bazel --windows_enable_symlinks test //tests/tools_tests:bzlformat_lint_test --enable_runfiles
@peakschris peakschris changed the title Tests fail on windows with %1 is not a valid Win32 application Tests fail on windows due to issues in bazel-starlib Jun 29, 2024
@peakschris peakschris mentioned this issue Jun 29, 2024
Merged
cgrindel pushed a commit that referenced this issue Jul 3, 2024
@peakschris
fix: windows functionality and tests (#334)
b40e501 
There are four issues when running on windows:

1.
#330
2.
#331
3.
#332
4.
#333

This PR fixes 3 and 4.

There are related PRs in bazel-skylib and bazel-starlib. There is no
dependency -- the PRs can close in any order.
- cgrindel/bazel-starlib#446 (fixes 1)
- bazelbuild/bazel-skylib#527 (fixes 2)

### Test results:
Before:
--enable_runfiles: 0 pass
--noenable_runfiles: 0 pass

After this PR:
--enable_runfiles: 52 pass, 19 failures
--noenable_runfiles: 51 pass, 20 failures (17 are doc diff-tests due to
bazel-starlib)

After this PR, together with wip PRs for 1 and 2:
--enable_runfiles: 71 pass, 0 failures
--noenable_runfiles: 51 pass, 20 failures (all due to bazel-starlib)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peakschris