Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table's wont convert #67

Closed
enginates opened this issue Sep 26, 2017 · 3 comments
Closed

Table's wont convert #67

enginates opened this issue Sep 26, 2017 · 3 comments
Labels
awaiting feedback This issue is awaiting feedback from the reporter feature A new business feature request A request for a new feature or enhancement stale This issue/PR has been inactive for too long

Comments

@enginates
Copy link

Report issue

Tables wont convert

Expected behavior

Converted tables

Actual Behavior

just send back html version

Steps to reproduce the problem

here is the example
table.txt

this table returns back as html table

@baynezy
Copy link
Owner

baynezy commented Sep 28, 2017

@enginates - thanks for the raising the issue. This project currently only supports markdown. If you look at the specification it stipulates that tables are not supported by intention. In fact it shouldn't even support other Markdown elements inside a certain block level elements. I have a bug to fix this #35

Now there are extensions to the Markdown format such as GitHub Flavoured Markdown which do support tables. This project does aspire to support these formats, but table conversion is actually pretty challenging.

Have a read of the <table> specification for GitHub Flavoured Markdown. Key things note are:-

  • No support for <th> in any position other than the entire first row
  • No support for block level elements in <th> or <td>
  • No support for multi-line content in <th> or <td>

So if I am to support this then I need help designing what should happen when tables that cannot be converted are encountered.

I hope that makes sense?

@baynezy baynezy added feature A new business feature request A request for a new feature or enhancement scheme:github-flavoured-markdown labels Sep 28, 2017
@baynezy baynezy added the awaiting feedback This issue is awaiting feedback from the reporter label Dec 13, 2023
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue/PR has been inactive for too long label Jan 13, 2024
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback This issue is awaiting feedback from the reporter feature A new business feature request A request for a new feature or enhancement stale This issue/PR has been inactive for too long
Projects
Status: Done
Development

No branches or pull requests

2 participants