Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ul-li elements not handled correctly #202

Closed
Viajaz opened this issue Jun 28, 2022 · 3 comments
Closed

ul-li elements not handled correctly #202

Viajaz opened this issue Jun 28, 2022 · 3 comments
Labels
awaiting feedback This issue is awaiting feedback from the reporter bug Something isn't working request A request for a new feature or enhancement stale This issue/PR has been inactive for too long

Comments

@Viajaz
Copy link

Viajaz commented Jun 28, 2022

Report issue

Tags inside li elements are not being converted. Unnecessary whitespace is also being produced.

Expected behavior

<ul>
    <li itemprop="itemListElement" itemscope="" itemtype="http://schema.org/ListItem">
              <p>Addresses a known issue that <b class="ocpLegacyBold"><u class="ocpUnderline">only affects Windows Arm-based devices</u></b> and might prevent you from signing in using Azure Active Directory (AAD). Apps and services that use AAD to sign in, such as VPN connections, Microsoft Teams, and Microsoft Outlook, might also be affected.</p>     
            <meta itemprop="position" content="1">
    </li>
  </ul>

-should be

* Addresses a known issue that **_only affects Windows Arm-based devices_** and might prevent you from signing in using Azure Active Directory (AAD). Apps and services that use AAD to sign in, such as VPN connections, Microsoft Teams, and Microsoft Outlook, might also be affected.

Actual Behaviour

*   

Addresses a known issue that <b class="ocpLegacyBold"><u class="ocpUnderline">only affects Windows Arm-based devices</u>** and might prevent you from signing in using Azure Active Directory (AAD). Apps and services that use AAD to sign in, such as VPN connections, Microsoft Teams, and Microsoft Outlook, might also be affected.</b>

  

Steps to reproduce the problem

Convert-

<ul>
    <li itemprop="itemListElement" itemscope="" itemtype="http://schema.org/ListItem">
              <p>Addresses a known issue that <b class="ocpLegacyBold"><u class="ocpUnderline">only affects Windows Arm-based devices</u></b> and might prevent you from signing in using Azure Active Directory (AAD). Apps and services that use AAD to sign in, such as VPN connections, Microsoft Teams, and Microsoft Outlook, might also be affected.</p>     
            <meta itemprop="position" content="1">
    </li>
  </ul>
@baynezy baynezy added bug Something isn't working request A request for a new feature or enhancement labels Dec 5, 2023
@baynezy baynezy added the awaiting review This pull request is awaiting review label Dec 13, 2023
@baynezy
Copy link
Owner

baynezy commented Dec 20, 2023

Thanks for adding this issue @Viajaz - I see the problem. However, there are a couple of things here to consider.

Firstly, the <u> tag does not have an equivalent in Markdown. So you cannot just convert it to an underscore.

Secondly, I might need to complete #45 before I can replace paragraph tags differently if they are in a <li>

@baynezy baynezy added awaiting feedback This issue is awaiting feedback from the reporter and removed awaiting review This pull request is awaiting review labels Dec 20, 2023
baynezy added a commit that referenced this issue Dec 21, 2023
Closes #359

May relate to #202

Massive thanks to https://github.com/YoussefAzaroual for most of the
work in #359
baynezy added a commit that referenced this issue Dec 21, 2023
Closes #359

May relate to #202

Massive thanks to https://github.com/YoussefAzaroual for most of the
work in #359
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue/PR has been inactive for too long label Jan 20, 2024
Copy link

github-actions bot commented Feb 4, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback This issue is awaiting feedback from the reporter bug Something isn't working request A request for a new feature or enhancement stale This issue/PR has been inactive for too long
Projects
None yet
Development

No branches or pull requests

2 participants